From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbcHNMbC (ORCPT ); Sun, 14 Aug 2016 08:31:02 -0400 Received: from gloria.sntech.de ([95.129.55.99]:41037 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbcHNMbB (ORCPT ); Sun, 14 Aug 2016 08:31:01 -0400 From: Heiko Stuebner To: Randy Li Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, mark.rutland@arm.com Subject: Re: [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for firefly reload Date: Sun, 14 Aug 2016 14:30:51 +0200 Message-ID: <35898684.O6p1GdTFI2@phil> User-Agent: KMail/5.2.3 (Linux/4.6.0-1-amd64; KDE/5.23.0; x86_64; ; ) In-Reply-To: <1471174044-26003-2-git-send-email-ayaka@soulik.info> References: <522097f6-8b5c-ee6d-c1b1-a63840228a0e@rock-chips.com> <1471174044-26003-1-git-send-email-ayaka@soulik.info> <1471174044-26003-2-git-send-email-ayaka@soulik.info> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, 14. August 2016, 19:27:23 CEST schrieb Randy Li: > Because of a bug in hardware design, the sdcard at firefly > rk3288 reload board can't switch the io voltage level to 1.8v. > > Signed-off-by: Randy Li > --- > arch/arm/boot/dts/rk3288-firefly-reload.dts | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts > b/arch/arm/boot/dts/rk3288-firefly-reload.dts index 43145d1..a2b1f14 100644 > --- a/arch/arm/boot/dts/rk3288-firefly-reload.dts > +++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts > @@ -202,18 +202,13 @@ > bus-width = <4>; > cap-mmc-highspeed; > cap-sd-highspeed; > - sd-uhs-sdr12; > - sd-uhs-sdr25; > - sd-uhs-sdr50; > - sd-uhs-sdr104; > - sd-uhs-ddr50; > card-detect-delay = <200>; > disable-wp; > num-slots = <1>; > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>; > vmmc-supply = <&vcc_sd>; > - vqmmc-supply = <&vccio_sd>; > + vqmmc-supply = <&vcc_sd>; that looks wrong. vccio_sd is still the vqmmc supply in the schematics even though we don't want to switch to 1.8V . But that regulator should still be controllable without needing a regulator-always-on in the future. Heiko