From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C3EC43461 for ; Sun, 11 Apr 2021 17:55:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AEBC6109F for ; Sun, 11 Apr 2021 17:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236119AbhDKRzh (ORCPT ); Sun, 11 Apr 2021 13:55:37 -0400 Received: from gloria.sntech.de ([185.11.138.130]:42092 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233822AbhDKRze (ORCPT ); Sun, 11 Apr 2021 13:55:34 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVeIe-0005oy-5c; Sun, 11 Apr 2021 19:55:08 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Peter Geis , Jianqun Xu , huangtao@rock-chips.com, kever.yang@rock-chips.com, linus.walleij@linaro.org, Johan Jonker Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] gpio: separate gpio driver from pinctrl-rockchip driver Date: Sun, 11 Apr 2021 19:55:07 +0200 Message-ID: <3591437.LM0AJKV5NW@diego> In-Reply-To: <5308a59c-29e9-75a4-2c9a-4aeb3d37bf6e@gmail.com> References: <20210411133030.1663936-1-pgwipeout@gmail.com> <20210411133030.1663936-4-pgwipeout@gmail.com> <5308a59c-29e9-75a4-2c9a-4aeb3d37bf6e@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, Am Sonntag, 11. April 2021, 19:51:52 CEST schrieb Johan Jonker: > Hi, > > When I check "rockchip,gpio-bank" with YAML it turns out that > rk3288-veyron-XXX has 'gpio-line-names' as 'extra' property. > It is not defined in the "rockchip,pinctrl.txt" document, but in > ~/.local/lib/python3.5/site-packages/dtschema/schemas/gpio/gpio.yaml > > Where is that in use? > In this driver or external? > Can it be removed from mainline dts? gpio-line-names gets defined in devicetree/bindings/gpio/gpio.txt which isn't converted to yaml yet: Optionally, a GPIO controller may have a "gpio-line-names" property. This is an array of strings defining the names of the GPIO lines going out of the GPIO controller. So that property is perfectly fine where it is. Heiko > > Johan > > /arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml: gpio7@ff7e0000: > 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' > From schema: > /Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > > On 4/11/21 3:30 PM, Peter Geis wrote: > > From: Jianqun Xu > > > > Separate the gpio driver from the pinctrl driver. > > > > Signed-off-by: Jianqun Xu > > --- >