Re: [PATCH v2 1/3] dt-bindings: media: rockchip-vpu: Add RK3568 VEPU compatible

Krzysztof Kozlowski
2022-05-09T07:29:35Z

On 08/05/2022 22:25, Nicolas Frattaroli wrote:
> The RK3568 and RK3566 have a Hantro VPU node solely dedicated to
> encoding. This patch adds a compatible for it, and also allows
> the bindings to only come with a vepu interrupt.
>
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
> Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> index bacb60a34989..4045f107ca4e 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> @@ -22,6 +22,7 @@ properties:
> - rockchip,rk3288-vpu
> - rockchip,rk3328-vpu
> - rockchip,rk3399-vpu
> + - rockchip,rk3568-vepu
> - rockchip,px30-vpu
> - items:
> - const: rockchip,rk3188-vpu
> @@ -40,6 +41,7 @@ properties:
> interrupt-names:
> oneOf:
> - const: vdpu
> + - const: vepu

This should be enum (for both lines above) and you should add
allOf:if:then with a constraints which variant can have which interrupts.

Best regards,
Krzysztof