From: Adrian Hunter <adrian.hunter@intel.com>
To: Erick Shepherd <erick.shepherd@ni.com>, <linux-kernel@vger.kernel.org>
Cc: <linux-mmc@vger.kernel.org>, <ulf.hansson@linaro.org>,
<gratian.crisan@emerson.com>,
Kyle Roeschley <kyle.roeschley@ni.com>,
"Brad Mouring" <brad.mouring@ni.com>
Subject: Re: [PATCH] mmc: core: Wait for Vdd to settle on card power off
Date: Wed, 5 Mar 2025 20:38:42 +0200 [thread overview]
Message-ID: <35aebb39-ae2e-4186-8de4-6830ec661f4d@intel.com> (raw)
In-Reply-To: <20250211214611.469260-1-erick.shepherd@ni.com>
On 11/02/25 23:46, Erick Shepherd wrote:
> The SD spec version 6.0 section 6.4.1.5 requires that Vdd must be
> lowered to less than 0.5V for a minimum of 1 ms when powering off a
> card. Increase our wait to 15 ms so that voltage has time to drain down
> to 0.5V.
mmc_power_off() has a delay. So does mmc_power_cycle()
Why does this need to be in sdhci? Are you experiencing an
issue?
>
> Signed-off-by: Kyle Roeschley <kyle.roeschley@ni.com>
> Signed-off-by: Brad Mouring <brad.mouring@ni.com>
> Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
> ---
> drivers/mmc/host/sdhci.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index f4a7733a8ad2..b15a1f107549 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2415,6 +2415,9 @@ void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> else
> sdhci_set_power(host, ios->power_mode, ios->vdd);
>
> + if (ios->power_mode == MMC_POWER_OFF)
> + mdelay(15);
> +
> if (host->ops->platform_send_init_74_clocks)
> host->ops->platform_send_init_74_clocks(host, ios->power_mode);
>
next prev parent reply other threads:[~2025-03-05 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 21:46 [PATCH] mmc: core: Wait for Vdd to settle on card power off Erick Shepherd
2025-02-13 10:22 ` Avri Altman
2025-03-05 18:38 ` Adrian Hunter [this message]
2025-03-07 17:46 ` Erick Shepherd
2025-03-07 18:53 ` Adrian Hunter
2025-03-07 21:16 ` Erick Shepherd
2025-03-12 12:44 ` Adrian Hunter
2025-03-13 3:35 ` Erick Shepherd
2025-03-13 8:20 ` Adrian Hunter
2025-03-13 20:44 ` Erick Shepherd
2025-03-14 5:56 ` Adrian Hunter
-- strict thread matches above, loose matches on Subject: below --
2017-09-21 17:47 Kyle Roeschley
2017-09-22 9:38 ` Ulf Hansson
2017-09-22 13:57 ` Kyle Roeschley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35aebb39-ae2e-4186-8de4-6830ec661f4d@intel.com \
--to=adrian.hunter@intel.com \
--cc=brad.mouring@ni.com \
--cc=erick.shepherd@ni.com \
--cc=gratian.crisan@emerson.com \
--cc=kyle.roeschley@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox