From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
krzysztof.kozlowski@linaro.org, pierre-louis.bossart@linux.dev,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org
Subject: Re: [PATCH] ASoC: q6apm-dai: schedule all the periods before we start streaming
Date: Mon, 3 Feb 2025 14:30:26 +0000 [thread overview]
Message-ID: <35cf66a2-05ef-4e49-a146-ca96ab19fcf8@linaro.org> (raw)
In-Reply-To: <357e28eb-f245-4647-8e10-79805b53731e@sirena.org.uk>
On 03/02/2025 14:17, Mark Brown wrote:
> On Mon, Feb 03, 2025 at 12:49:45PM +0000, srinivas.kandagatla@linaro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> With the existing code, we are only setting up one period at a time, in a
>> ping-pong buffer style. This tiggers lot of underruns in the dsp
>> leading to jitter noise during audio playback.
>>
>> Fix this by scheduling all the periods, this will ensure that the dsp
>> has enough buffer feed and ultimatley fixing the underruns and audio
>> distortion.
>
> Should we be writing all periods or just the minimum number of periods
> that's configured? Userspace might not have filled the whole buffer
> yet.
Just minimum number of periods or 1 period. We are queuing up all the
periods to the DSP, so that we do not have to wait for period interrupt
to queue the next one. This significantly reduces the latency in queuing
the periods to dsp.
--srini
next prev parent reply other threads:[~2025-02-03 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 12:49 [PATCH] ASoC: q6apm-dai: schedule all the periods before we start streaming srinivas.kandagatla
2025-02-03 14:09 ` Dmitry Baryshkov
2025-02-03 14:12 ` Srinivas Kandagatla
2025-02-03 14:17 ` Mark Brown
2025-02-03 14:30 ` Srinivas Kandagatla [this message]
2025-02-03 15:07 ` Mark Brown
2025-02-03 17:04 ` Srinivas Kandagatla
2025-02-03 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35cf66a2-05ef-4e49-a146-ca96ab19fcf8@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox