From: Paolo Bonzini <pbonzini@redhat.com>
To: Yosry Ahmed <yosry.ahmed@linux.dev>,
Sean Christopherson <seanjc@google.com>
Cc: Jim Mattson <jmattson@google.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] KVM: SVM: LBR virtualization fixes
Date: Sun, 9 Nov 2025 08:57:20 +0100 [thread overview]
Message-ID: <35d28432-349c-4157-8c9e-7d4a9d8bd50f@redhat.com> (raw)
In-Reply-To: <20251108004524.1600006-1-yosry.ahmed@linux.dev>
On 11/8/25 01:45, Yosry Ahmed wrote:
> This series fixes multiple problems with LBR virtualization, including a
> fun problem that leads to L1 reading the host's LBR MSRs. It also
> considerably simplifies the code.
>
> The series has a selftest in the end that verifies that save/restore
> work correctly. I will send a couple of new kvm-unit-tests separately
> that exercise the bugs fixed by patches 2 & 3.
Thanks, I've applied patches 1-3 for now.
Save/restore has been broken for 17 years so it can wait the next
release anyway. :)
Paolo
>
> Yosry Ahmed (6):
> KVM: SVM: Mark VMCB_LBR dirty when MSR_IA32_DEBUGCTLMSR is updated
> KVM: nSVM: Always recalculate LBR MSR intercepts in svm_update_lbrv()
> KVM: nSVM: Fix and simplify LBR virtualization handling with nested
> KVM: SVM: Switch svm_copy_lbrs() to a macro
> KVM: SVM: Add missing save/restore handling of LBR MSRs
> KVM: selftests: Add a test for LBR save/restore (ft. nested)
>
> arch/x86/kvm/svm/nested.c | 31 ++--
> arch/x86/kvm/svm/svm.c | 98 ++++++-----
> arch/x86/kvm/svm/svm.h | 10 +-
> arch/x86/kvm/x86.c | 3 +
> tools/testing/selftests/kvm/Makefile.kvm | 1 +
> .../selftests/kvm/include/x86/processor.h | 5 +
> .../selftests/kvm/x86/svm_lbr_nested_state.c | 155 ++++++++++++++++++
> 7 files changed, 236 insertions(+), 67 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/x86/svm_lbr_nested_state.c
>
prev parent reply other threads:[~2025-11-09 7:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 0:45 [PATCH 0/6] KVM: SVM: LBR virtualization fixes Yosry Ahmed
2025-11-08 0:45 ` [PATCH 1/6] KVM: SVM: Mark VMCB_LBR dirty when MSR_IA32_DEBUGCTLMSR is updated Yosry Ahmed
2025-11-09 7:42 ` Paolo Bonzini
2025-11-08 0:45 ` [PATCH 2/6] KVM: nSVM: Always recalculate LBR MSR intercepts in svm_update_lbrv() Yosry Ahmed
2025-11-11 3:11 ` Yosry Ahmed
2025-11-11 18:55 ` Yosry Ahmed
2025-11-11 22:30 ` Sean Christopherson
2025-11-08 0:45 ` [PATCH 3/6] KVM: nSVM: Fix and simplify LBR virtualization handling with nested Yosry Ahmed
2025-11-08 0:45 ` [PATCH 4/6] KVM: SVM: Switch svm_copy_lbrs() to a macro Yosry Ahmed
2025-11-09 7:59 ` Paolo Bonzini
2025-11-10 19:23 ` Yosry Ahmed
2025-11-10 19:41 ` Sean Christopherson
2025-11-08 0:45 ` [PATCH 5/6] KVM: SVM: Add missing save/restore handling of LBR MSRs Yosry Ahmed
2025-11-08 9:08 ` Yosry Ahmed
2025-11-08 0:45 ` [PATCH 6/6] KVM: selftests: Add a test for LBR save/restore (ft. nested) Yosry Ahmed
2025-11-09 7:57 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d28432-349c-4157-8c9e-7d4a9d8bd50f@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).