Re: [PATCH 1/1] security: Used macros from compiler.h instead of __attribute__((...))

[Paul Moore <paul@paul-moore.com>]

On Wednesday, June 11, 2014 09:25:30 PM Gideon Israel Dsouza wrote:
> To increase compiler portability there is <linux/compiler.h> which
> provides convenience macros for various gcc constructs.  Eg: __packed
> for __attribute__((packed)).
> 
> This patch is part of a large task I've taken to clean the gcc
> specific attributes and use the the macros instead.
> 
> Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com>
> ---
>  security/selinux/include/security.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

>From what I can tell this should still work with both the LLVM and Intel 
compilers, is that correct?

> diff --git a/security/selinux/include/security.h
> b/security/selinux/include/security.h index ce7852c..ff19bcc 100644
> --- a/security/selinux/include/security.h
> +++ b/security/selinux/include/security.h
> @@ -8,6 +8,7 @@
>  #ifndef _SELINUX_SECURITY_H_
>  #define _SELINUX_SECURITY_H_
> 
> +#include <linux/compiler.h>
>  #include <linux/dcache.h>
>  #include <linux/magic.h>
>  #include <linux/types.h>
> @@ -220,7 +221,7 @@ struct selinux_kernel_status {
>  	/*
>  	 * The version > 0 supports above members.
>  	 */
> -} __attribute__((packed));
> +} __packed;
> 
>  extern void selinux_status_update_setenforce(int enforcing);
>  extern void selinux_status_update_policyload(int seqno);

-- 
paul moore
www.paul-moore.com