public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	"Li, Philip" <philip.li@intel.com>
Subject: Re: [GIT PULL] Thermal management updates for v4.17-rc1
Date: Fri, 13 Apr 2018 12:27:17 +0200	[thread overview]
Message-ID: <3605298.EUomHGJ8vH@amdc3058> (raw)
In-Reply-To: <20180413100801.GA21913@localhost.localdomain>

On Friday, April 13, 2018 03:08:03 AM Eduardo Valentin wrote:
> On Fri, Apr 13, 2018 at 01:39:05PM +0800, Zhang Rui wrote:
> > Hi, Eduardo,
> > 
> > On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote:
> > > Hello,
> > > 
> > > On Thu, Apr 12, 2018 at 09:55:19AM -0700, Linus Torvalds wrote:
> > > > 
> > > > On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui <rui.zhang@intel.com>
> > > > wrote:
> > > > > 
> > > > > 
> > > > > could you please illustrate me what the kconfig & warning is?
> > > > Just "make allmodconfig" and the warning is about a uninitialized
> > > > variable.
> > > > 
> > > > Line 304 in drivers/thermal/samsung/exynos_tmu.c if my shell
> > > > history
> > > > is to be believed.
> > > > 
> > > >                 Linus
> > > Yeah, this has also passed my local compilation error. Somehow my
> > > gcc4.9
> > > is not catching it. Using an older gcc (gcc4.6) does catch it.
> > > 
> > > Anyways, given that the conversion functions are written to cover
> > > for unexpected cal_type, the right way of fixing this is to rewrite
> > > the conversion functions to allow for returning error codes and
> > > adjusting the callers as expected.
> > > 
> > > Rui, bzolnier, please consider the following fix:
> > > 
> > as it is late in this merge window, I'd prefer to
> > 1. drop all the thermal-soc material in the first pull request which I
> > will send out soon.
> > 2. you can prepare another pull request containing the thermal-soc
> > materials except the exynos fixes
> > 3. exynos fixes with the problem solved can be queued for -rc2 or
> > later.
> > 
> 
> Agreed

What should I do now to help resolve the issue?

[ There has been no action from you on Arnd's fix for over two weeks and
  also you have not commented on it now.. ]

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  parent reply	other threads:[~2018-04-13 10:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11  8:41 [GIT PULL] Thermal management updates for v4.17-rc1 Zhang Rui
2018-04-12  0:01 ` Linus Torvalds
2018-04-12  5:08   ` Zhang Rui
2018-04-12 16:55     ` Linus Torvalds
2018-04-12 17:42       ` Daniel Lezcano
2018-04-13  4:08       ` Eduardo Valentin
2018-04-13  5:29         ` Zhang Rui
2018-04-13  5:39         ` Zhang Rui
2018-04-13  8:55           ` Bartlomiej Zolnierkiewicz
2018-04-13  9:00             ` Daniel Lezcano
2018-04-13  9:08               ` Bartlomiej Zolnierkiewicz
2018-04-13  9:19                 ` Daniel Lezcano
2018-04-13  9:28                   ` Bartlomiej Zolnierkiewicz
2018-04-13 10:30                     ` Daniel Lezcano
2018-04-13 10:41                       ` Bartlomiej Zolnierkiewicz
2018-04-13 11:00                         ` [PATCH] thermal/drivers/exynos_tmu: Fix warnings in temp_to_code / code_to_temp Daniel Lezcano
2018-04-13 11:08                           ` Bartlomiej Zolnierkiewicz
2018-04-13 11:10                         ` [GIT PULL] Thermal management updates for v4.17-rc1 Daniel Lezcano
2018-04-13 11:12                         ` Bartlomiej Zolnierkiewicz
2018-04-13 11:21                           ` Bartlomiej Zolnierkiewicz
2018-04-13 10:08           ` Eduardo Valentin
2018-04-13 10:25             ` Eduardo Valentin
2018-04-13 10:27             ` Bartlomiej Zolnierkiewicz [this message]
2018-04-15  8:51               ` Eduardo Valentin
2018-04-13  8:50         ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3605298.EUomHGJ8vH@amdc3058 \
    --to=b.zolnierkie@samsung.com \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=philip.li@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox