From: youquan_song@linux.intel.com
To: linux-acpi@vger.kernel.org
Cc: venkatesh.pallipadi@intel.com, len.brown@intel.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI: Check _PSS invalidation when BIOS report _PSS with all 0x80000000
Date: Thu, 20 Nov 2008 19:08:36 -0800 (PST) [thread overview]
Message-ID: <3606.172.16.183.72.1227236916.squirrel@linux.intel.com> (raw)
Subject: Check _PSS invalidation when BIOS report _PSS with 0x80000000
When cpu frequencey scaling disable,some BIOS report _PSS with all
0x80000000.
If kernel treat this case as valid, the kernel will boot crash when load
cpufreq govenors.
So in order to cover more buggy BIOSs, the patch just check _PSS core
frequencey invalidtion.
Signed-off-by: Youquan, Song <youquan.song@intel.com>
Signed-off-by: Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com>
---
--- linux-2.6-tip-orignal/drivers/acpi/processor_perflib.c 2008-11-20
12:25:05.000000000 -0500
+++ linux-2.6-tip/drivers/acpi/processor_perflib.c 2008-11-20
12:23:57.000000000 -0500
@@ -50,6 +50,7 @@
#define ACPI_PROCESSOR_CLASS "processor"
#define ACPI_PROCESSOR_FILE_PERFORMANCE "performance"
#define _COMPONENT ACPI_PROCESSOR_COMPONENT
+#define ACPI_PROCESSOR_PSS_INVALID 0x80000000
ACPI_MODULE_NAME("processor_perflib");
static DEFINE_MUTEX(performance_mutex);
@@ -324,6 +325,14 @@
kfree(pr->performance->states);
goto end;
}
+
+ if (px->core_frequency == ACPI_PROCESSOR_PSS_INVALID) {
+ printk(KERN_ERR PREFIX
+ "P-states disabled in the BIOS\n");
+ result = -EFAULT;
+ kfree(pr->performance->states);
+ goto end;
+ }
}
end:
next reply other threads:[~2008-11-21 3:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 3:08 youquan_song [this message]
2008-11-21 23:08 ` [PATCH] ACPI: Check _PSS invalidation when BIOS report _PSS with all 0x80000000 Andrew Morton
2008-11-24 23:02 ` Youquan,Song
2008-12-12 5:36 ` Len Brown
2009-03-12 13:22 ` Woody Suwalski
2009-03-13 2:16 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3606.172.16.183.72.1227236916.squirrel@linux.intel.com \
--to=youquan_song@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox