From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933623AbeB1Pvj (ORCPT ); Wed, 28 Feb 2018 10:51:39 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:52264 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933272AbeB1Pvg (ORCPT ); Wed, 28 Feb 2018 10:51:36 -0500 Subject: Re: [PATCH] arm64: dts: juno: fix size of GICv2m MSI frames To: Sudeep Holla , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Liviu Dudau , Marc Zyngier References: <20180207143255.17003-3-marc.zyngier@arm.com> <1519832935-7338-1-git-send-email-sudeep.holla@arm.com> From: Robin Murphy Message-ID: <36126393-ee37-40f1-9d5d-1c7f25c648dc@arm.com> Date: Wed, 28 Feb 2018 15:51:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519832935-7338-1-git-send-email-sudeep.holla@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, Cheers for sorting it out... On 28/02/18 15:48, Sudeep Holla wrote: > Currently the size of GICv2m MSI frames are listed as 4kB while the > Juno TRM specifies 64kB for each of these MSI frames. > > Though the devices connected themself might just use the first 4kB, s/themself/themselves/ > to be consistent with the genaral practice of 64kB boundary alignment s/genaral/general/ > to all the devices, lets keep the size as 64kB. This might also help > in avoiding any surprise when passing the device to a VM. > > This patch increase the size of each GICv2m MSI frames from 4kB to 64kB > as per the specification. Reviewed-by: Robin Murphy > Cc: Liviu Dudau > Cc: Robin Murphy > Cc: Marc Zyngier > Signed-off-by: Sudeep Holla > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index f8088c45b060..eb749c50a736 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -72,25 +72,25 @@ > v2m_0: v2m@0 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0 0 0x1000>; > + reg = <0 0 0 0x10000>; > }; > > v2m@10000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x10000 0 0x1000>; > + reg = <0 0x10000 0 0x10000>; > }; > > v2m@20000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x20000 0 0x1000>; > + reg = <0 0x20000 0 0x10000>; > }; > > v2m@30000 { > compatible = "arm,gic-v2m-frame"; > msi-controller; > - reg = <0 0x30000 0 0x1000>; > + reg = <0 0x30000 0 0x10000>; > }; > }; > >