Re: [linux-sunxi] Re: [PATCH v2 01/11] dt-bindings: update the binding for Allwinner H3 TVE support

icenowy
2017-06-10T15:26:53Z

在 2017-06-10 05:24，Jernej Škrabec 写道：
> Hi!
>
> Dne petek, 09. junij 2017 ob 18:51:02 CEST je Icenowy Zheng napisal(a):
>> 于 2017年6月10日 GMT+08:00 上午12:49:15, Maxime Ripard <maxime.ripard@free-
> electrons.com> 写到:
>> >On Wed, Jun 07, 2017 at 04:48:50PM +0800, Icenowy Zheng wrote:
>> >> >> @@ -189,6 +211,8 @@ supported.
>> >> >>
>> >> >> Required properties:
>> >> >> - compatible: value must be one of:
>> >> >> * allwinner,sun8i-v3s-de2-mixer
>> >> >>
>> >> >> + * allwinner,sun8i-h3-de2-mixer0
>> >> >> + * allwinner,sun8i-h3-de2-mixer1
>> >> >
>> >> >Again, please explain why we need to have different compatibles
>> >> >here. If it's only about the number of planes, this should be dealt
>> >> >with a property, not a compatible.
>> >>
>> >> Only mixer0 has "VEP" and write-back support, at least on H3.
>> >
>> >What is that VEP? writeback support can also be expressed by a
>> >property.
>>
>> I don't know what VEP is...
>
> VEP is probably Video Enhancement Processor (?). Although I'm not sure
> if that
> is really mixer specific. Icenowy, can you explain where did you get
> this info?

In
lichee/linux-3.4/drivers/video/sunxi/disp2/disp/de/lowlevel_sun8iw7/de_feat.c:

static const int de_is_support_vep[] = {
/* DISP0 CH0 */
1,
/* DISP0 CH1 */
0,
/* DISP0 CH2 */
0,
/* DISP0 CH3 */
0,
/* DISP1 CH0 */
0,
/* DISP1 CH1 */
0,
};

>
> Best regards,
> Jernej
>
>>
>> But we are really facing different cores, like sun50i-a64-mmc
>> and sun50i-a64-emmc.
>>
>> >Maxime
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups
>> "linux-sunxi" group. To unsubscribe from this group and stop receiving
>> emails from it, send an email to
>> linux-sunxi+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.