From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677AbcHHUfs (ORCPT ); Mon, 8 Aug 2016 16:35:48 -0400 Received: from gloria.sntech.de ([95.129.55.99]:37722 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbcHHUfq (ORCPT ); Mon, 8 Aug 2016 16:35:46 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Roger Chen Cc: linux-rockchip@lists.infradead.org, zhengxing@rock-chips.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, davem@davemloft.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/3] net: stmmac: dwmac-rk: add rk3366 & rk3399-specific data Date: Mon, 08 Aug 2016 22:35:29 +0200 Message-ID: <3635712.eAtD6Fn9AW@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1467802291-6487-2-git-send-email-roger.chen@rock-chips.com> References: <1467802291-6487-1-git-send-email-roger.chen@rock-chips.com> <1467802291-6487-2-git-send-email-roger.chen@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, Am Mittwoch, 6. Juli 2016, 18:51:29 schrieb Roger Chen: > Add constants and callback functions for the dwmac on rk3368 socs. > As can be seen, the base structure is the same, only registers and > the bits in them moved slightly. > > Signed-off-by: Roger Chen > --- > .../devicetree/bindings/net/rockchip-dwmac.txt | 3 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 226 > +++++++++++++++++++++ 2 files changed, 228 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt > b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt index > 93eac7c..8c066e6 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt > @@ -3,7 +3,8 @@ Rockchip SoC RK3288 10/100/1000 Ethernet driver(GMAC) > The device node has following properties. > > Required properties: > - - compatible: Can be one of "rockchip,rk3288-gmac", "rockchip,rk3368-gmac" > + - compatible: Can be one of "rockchip,rk3288-gmac", > "rockchip,rk3366-gmac", + > "rockchip,rk3368-gmac", "rockchip,rk3399-gmac" - reg: addresses and length > of the register sets for the device. - interrupts: Should contain the GMAC > interrupts. > - interrupt-names: Should contain the interrupt names "macirq". this doesn't apply against 4.8-rc1 anymore, can you please rebase and resend the series? Thanks Heiko