public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: [PATCH 21/28] readahead: thrashing recovery method
Date: Wed, 15 Nov 2006 15:50:28 +0800	[thread overview]
Message-ID: <363577027.13886@ustc.edu.cn> (raw)
Message-ID: <20061115075031.286178806@localhost.localdomain> (raw)
In-Reply-To: 20061115075007.832957580@localhost.localdomain

[-- Attachment #1: readahead-thrashing-recovery-method.patch --]
[-- Type: text/plain, Size: 1732 bytes --]

Readahead policy after thrashing.

It tries to recover gracefully from the thrashing.

Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
Signed-off-by: Andrew Morton <akpm@osdl.org>
--- linux-2.6.19-rc5-mm2.orig/mm/readahead.c
+++ linux-2.6.19-rc5-mm2/mm/readahead.c
@@ -1522,6 +1522,50 @@ try_backward_prefetching(struct file_ra_
 }
 
 /*
+ * Readahead thrashing recovery.
+ */
+static unsigned long
+thrashing_recovery_readahead(struct address_space *mapping,
+				struct file *filp, struct file_ra_state *ra,
+				pgoff_t offset, unsigned long ra_max)
+{
+	unsigned long ra_size;
+
+#ifdef CONFIG_DEBUG_READAHEAD
+	if (probe_page(mapping, offset - 1))
+		ra_account(ra, RA_EVENT_READAHEAD_MUTILATE,
+						ra->readahead_index - offset);
+	ra_account(ra, RA_EVENT_READAHEAD_THRASHING,
+						ra->readahead_index - offset);
+#endif
+
+	/*
+	 * Some thrashing occur in (ra_index, la_index], in which case the
+	 * old read-ahead chunk is lost soon after the new one is allocated.
+	 * Ensure that we recover all needed pages in the old chunk.
+	 */
+	if (offset < ra->ra_index)
+		ra_size = ra->ra_index - offset;
+	else {
+		/* After thrashing, we know the exact thrashing-threshold. */
+		ra_size = offset - ra->ra_index;
+		update_ra_thrash_bytes(mapping->backing_dev_info, ra_size);
+
+		/* And we'd better be a bit conservative. */
+		ra_size = ra_size * 3 / 4;
+	}
+
+	if (ra_size > ra_max)
+		ra_size = ra_max;
+
+	ra_set_class(ra, RA_CLASS_THRASHING);
+	ra_set_index(ra, offset, offset);
+	ra_set_size(ra, ra_size, ra_size / LOOKAHEAD_RATIO);
+
+	return ra_submit(ra, mapping, filp);
+}
+
+/*
  * ra_min is mainly determined by the size of cache memory. Reasonable?
  *
  * Table of concrete numbers for 4KB page size:

--

  parent reply	other threads:[~2006-11-15  7:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061115075007.832957580@localhost.localdomain>
2006-11-15  7:50 ` [PATCH 00/28] Adaptive readahead V16 Wu Fengguang
     [not found] ` <20061115075024.180138257@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 01/28] readahead: kconfig options Wu Fengguang
     [not found] ` <20061115075024.503627543@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 02/28] radixtree: introduce scan hole/data functions Wu Fengguang
     [not found] ` <20061115075024.850542829@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 03/28] mm: introduce probe_page() Wu Fengguang
     [not found] ` <20061115075025.438524224@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 04/28] mm: introduce PG_readahead Wu Fengguang
     [not found] ` <20061115075026.121499794@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 06/28] readahead: insert cond_resched() calls Wu Fengguang
     [not found] ` <20061115075027.139255636@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 09/28] readahead: rescue_pages() Wu Fengguang
     [not found] ` <20061115075027.832896629@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 11/28] readahead: min/max sizes Wu Fengguang
     [not found] ` <20061115075028.178039166@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 12/28] readahead: state based method - aging accounting Wu Fengguang
2006-11-15 16:54     ` Christoph Lameter
     [not found]       ` <20061116133919.GA6645@mail.ustc.edu.cn>
2006-11-16 13:39         ` Wu Fengguang
     [not found] ` <20061115075028.494374406@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 13/28] readahead: state based method - routines Wu Fengguang
     [not found] ` <20061115075028.829507795@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 14/28] readahead: state based method Wu Fengguang
     [not found] ` <20061115075029.205178794@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 15/28] readahead: context " Wu Fengguang
     [not found] ` <20061115075029.519507130@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 16/28] readahead: initial method - guiding sizes Wu Fengguang
     [not found] ` <20061115075029.869472273@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 17/28] readahead: initial method - thrashing guard size Wu Fengguang
     [not found] ` <20061115075030.229339867@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 18/28] readahead: initial method - user recommended size Wu Fengguang
     [not found] ` <20061115075030.942942737@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 20/28] readahead: backward prefetching method Wu Fengguang
     [not found] ` <20061115075031.286178806@localhost.localdomain>
2006-11-15  7:50   ` Wu Fengguang [this message]
     [not found] ` <20061115075031.524129110@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 22/28] readahead: call scheme Wu Fengguang
     [not found] ` <20061115075031.909090639@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 23/28] readahead: laptop mode Wu Fengguang
     [not found] ` <20061115075032.213167260@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 24/28] readahead: loop case Wu Fengguang
     [not found] ` <20061115075032.515501374@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 25/28] readahead: nfsd case Wu Fengguang
     [not found] ` <20061115075032.945192537@localhost.localdomain>
2006-11-15  7:50   ` [PATCH 26/28] readahead: turn on by default Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=363577027.13886@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox