From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161350AbcHaRvN (ORCPT ); Wed, 31 Aug 2016 13:51:13 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:41753 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753902AbcHaRu7 (ORCPT ); Wed, 31 Aug 2016 13:50:59 -0400 X-AuditID: cbfee61b-f79466d000001e3c-88-57c719004afb From: Bartlomiej Zolnierkiewicz To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Krzysztof Kozlowski Subject: Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Date: Wed, 31 Aug 2016 19:22:51 +0200 Message-id: <3638650.aebblMKNhB@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1472645679-5696-2-git-send-email-javier@osg.samsung.com> References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com> <1472645679-5696-2-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t9jAV0GyePhBncnWVrMP3KO1eLN2zVM Fv2PXzNbnD+/gd3i8q45bBYzzu9jslh6/SKTReveI+wOHB5r5q1h9Ni0qpPNY0v/XXaPz5vk AliiuGxSUnMyy1KL9O0SuDImbZ3JVHBeqOL351bWBsap/F2MHBwSAiYS9985dDFyApliEhfu rWfrYuTiEBJYyijR93w+K4TzlVHi5fFHrCBVbAJWEhPbVzGC2CICphK/1r4AK2IW+MQo8WLZ R3aQhLBAlMSpg6uYQWwWAVWJRQ8Os4HYvAKaEnvn3wRrFhXwkujZ/ogR5ApOATeJo2crIJY1 Mkp8v3ecCaJeUOLH5HssIDazgLzEvv1TWSFsLYn1O48zTWAUmIWkbBaSsllIyhYwMq9ilEgt SC4oTkrPNcpLLdcrTswtLs1L10vOz93ECA72Z9I7GA/vcj/EKMDBqMTD6/DmWLgQa2JZcWXu IUYJDmYlEd5c8ePhQrwpiZVVqUX58UWlOanFhxilOViUxHkf/18XJiSQnliSmp2aWpBaBJNl 4uCUamDcGz8hZ/2LUBbxQ2ffzL1//NyBnTvt4oQSTrNnWsr8LM6WnmyilHh+V+F0wUSriLnN C/K3bj2QfLzYflejcmv811pGJx+uQ5Xit1eue9rUeHbyZpED7kkFJzPWmngpbJxzlq9NJGuH e5jvq5yL6SHPej2ZFq5V+iFUO9fWNeujNHfB/6yZ6ixKLMUZiYZazEXFiQDEWXf0cgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote: > The skeleton.dtsi file was removed in ARM64 for different reasons as > explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi"). > > These also applies to ARM and it will also allow to get rid of the > following DTC warnings in the future: > > "Node /memory has a reg or ranges property, but no unit name" > > But these boards don't have a memory node defined, so removing the > skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the > compiled DTB. Add a dummy memory node so the compiled DTB doesn't > change if the skeleton.dtsi is removed from exynos4.dtsi. > > Eventually the correct starting addresses and sizes should be used > but I didn't find that information. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5440-sd5v1.dts | 5 +++++ > arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts > index a98501bab6fc..333db4ff373a 100644 > --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts > +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts > @@ -20,6 +20,11 @@ > bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200"; > }; > > + memory { > + device_type = "memory"; > + reg = <0 0>; > + }; I think that this node deserves a FIXME comment. > + > fixed-rate-clocks { > xtal { > compatible = "samsung,clock-xtal"; > diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts > index 6a0d802e87c8..82fea6f94704 100644 > --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts > +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts > @@ -21,6 +21,11 @@ > bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200"; > }; > > + memory { > + device_type = "memory"; > + reg = <0 0>; > + }; ditto > fixed-rate-clocks { > xtal { > compatible = "samsung,clock-xtal"; > Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics