public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Angelo Dureghello <angelo@sysam.it>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68knommu: remove dead code
Date: Sun, 27 Aug 2017 13:22:09 +0200	[thread overview]
Message-ID: <363abb76-2001-f072-fd8e-332014ee07e0@sysam.it> (raw)
In-Reply-To: <20170824143407.21273-1-alexandre.belloni@free-electrons.com>

Hi,

just to inform you that i have in mind to add spi(soon, at least seems
just a matter con Kconfig changes) and usdhc(later)
drivers/support for stmark2 mcf5441x based board.
But no problem, in case i'll re-add the this code as needed.

On 24/08/2017 16:34, Alexandre Belloni wrote:
> As CONFIG_RTC_DRV_M5441x doesn't exist because the driver never made it
> upstream, there is no device to register. Remove code that is never
> compiled and init_BSP() as it doesn't do anything.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>   arch/m68k/coldfire/m5441x.c | 37 -------------------------------------
>   1 file changed, 37 deletions(-)
> 
> diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> index dc589b039b62..04fd7fde9fb3 100644
> --- a/arch/m68k/coldfire/m5441x.c
> +++ b/arch/m68k/coldfire/m5441x.c
> @@ -222,40 +222,3 @@ void __init config_BSP(char *commandp, int size)
>   	m5441x_uarts_init();
>   	m5441x_fec_init();
>   }
> -
> -
> -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> -static struct resource m5441x_rtc_resources[] = {
> -	{
> -		.start		= MCFRTC_BASE,
> -		.end		= MCFRTC_BASE + MCFRTC_SIZE - 1,
> -		.flags		= IORESOURCE_MEM,
> -	},
> -	{
> -		.start		= MCF_IRQ_RTC,
> -		.end		= MCF_IRQ_RTC,
> -		.flags		= IORESOURCE_IRQ,
> -	},
> -};
> -
> -static struct platform_device m5441x_rtc = {
> -	.name			= "mcfrtc",
> -	.id			= 0,
> -	.resource		= m5441x_rtc_resources,
> -	.num_resources		= ARRAY_SIZE(m5441x_rtc_resources),
> -};
> -#endif
> -
> -static struct platform_device *m5441x_devices[] __initdata = {
> -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> -	&m5441x_rtc,
> -#endif
> -};
> -
> -static int __init init_BSP(void)
> -{
> -	platform_add_devices(m5441x_devices, ARRAY_SIZE(m5441x_devices));
> -	return 0;
> -}
> -
> -arch_initcall(init_BSP);
> 

Regards,
Angelo

  parent reply	other threads:[~2017-08-27 11:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 14:34 [PATCH] m68knommu: remove dead code Alexandre Belloni
2017-08-25  1:24 ` Greg Ungerer
2017-08-27 11:22 ` Angelo Dureghello [this message]
2017-08-27 19:09   ` Alexandre Belloni
2017-08-27 19:36     ` Steven King
2017-08-27 21:11       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=363abb76-2001-f072-fd8e-332014ee07e0@sysam.it \
    --to=angelo@sysam.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox