From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay47-hz3.antispameurope.com (mx-relay47-hz3.antispameurope.com [94.100.134.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A1AA3AE189 for ; Wed, 4 Mar 2026 14:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=94.100.134.236 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772633765; cv=pass; b=r1urH19qHe9n3xifBKIg0+iEc/auyQrfrydq3h7sl0R6dwv1F7vjp7Tq+CCLMIUctX4hbuYBt/5otT0CEdB7loGObDIQuOOzct4havOvYB9xW6q5q+fu+NGBZyepENh432qLge+on1XgjOWv8pu5ZmtzTMM74EOG0NgG8Fv0ZBs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772633765; c=relaxed/simple; bh=M8N8n08iO/ohnjBo++QVndSj6M5N7aaFg3GXa++LBzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hu/RMpFvJGVfigvkhWC4r0HzSADGbN2S92eL0WpWMapK2uVP9DmrpBlVFSxigZmvg/XhnpjDv98Gb48P/DAjBJOJIYsZMJSYlpP3hIodWPzEjmahkZwoIjFBe9z53WQSk9+j5ydsatbl4Q/bSGg5NzGr/2+wRwEVvEGbc8vvlpg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=BEVAnJrW; arc=pass smtp.client-ip=94.100.134.236 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="BEVAnJrW" ARC-Authentication-Results: i=1; mx-gate47-hz3.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=hmail-p-smtp01-out04-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=FYFA42ojX02uc6vcNPxxquciL8D8ZUQxPHLK9Ii1tuk=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1772633705; b=ob71dOuUhxjhOdfcXdEzI1nPVk5rNKNMqijisJMBTZHoxCuVZJQN2GRcd6IN5rVccdFqS/cF D2hcLav/7UsnNf1MjudyOfWgJM0zVi3DqhwDn1nJtWg0QDM6pV0oiKcw1WPzK9tTN1nZEpMrBT1 NkwV2YVSby9frUI28VS9jAxF6dOhgBxu7Sx8UHb0H8luLHmGZouvvcnVLxnf7oFcFbAszpHhzFf s/5u2maiitoJqRefVZQX8pzvWLbOyNo5qdpiX4o1xGMbrpjEIS66Rb2PwsHrQkT1ux1EVaOCmOD KfXZo4OHNTZAx99GSQ+Y3Rk23HL3X510nqfC4MlSOIqgw== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1772633705; b=jjcJqw+rMjOAVPoQAHg7rizM8LVzD0XD7v7KHqmE1cXGmky9xJ9/+Afc+d0XgPoqO88uK0M0 V6rp4nCOg7o3lIXkT4Ck4H8cNdxhM1KDHoQdQFFM8mIJW1VFyvXwIhd/eXTR/l+cQ9YVToe0S4e nR3FrPji8LQ+gamNcXG0EznyTH4i5u9Aqw4ZlKEvDkSjeTuFvMi8wNkY1k4IeBu6D6JdOMplBo6 Ev9+E3V8Fr/I1f6To6yjzkJGGquP3YCKtLGioM2Z0JdzOGkij3gcK50JEXpBs5dSxC2ZJK7uW9W p+4GqkW1eKQYgFrg0u++cXUTrUoKQMtUGxI1o+c8ODlTw== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay47-hz3.antispameurope.com; Wed, 04 Mar 2026 15:15:05 +0100 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by hmail-p-smtp01-out04-hz1.hornetsecurity.com (Postfix) with ESMTPSA id 35234220EC7; Wed, 4 Mar 2026 15:14:55 +0100 (CET) From: Alexander Stein To: Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Vinod Koul , Michal Simek , Max Zhen , Sonal Santan Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] dmaengine: xilinx: xdma: Fix regmap init error handling Date: Wed, 04 Mar 2026 15:14:55 +0100 Message-ID: <3640054.irdbgypaU6@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20251014061309.283468-1-alexander.stein@ew.tq-group.com> References: <20251014061309.283468-1-alexander.stein@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart15345406.uLZWGnKmhe"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-cloud-security-sender:alexander.stein@ew.tq-group.com X-cloud-security-recipient:linux-kernel@vger.kernel.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay47-hz3.antispameurope.com with 4fQvnW5SSxz4Mb6T X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:18b88d27d6f57275e2308e9afc64a81d X-cloud-security:scantime:2.059 DKIM-Signature: a=rsa-sha256; bh=FYFA42ojX02uc6vcNPxxquciL8D8ZUQxPHLK9Ii1tuk=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1772633705; v=1; b=BEVAnJrWazVszdsxcldMMe/hhDWePbiGkLQwhNo0JpBjaFq/W7gpbCVViPpi9RNPGUWcqQVi qcmW30L9O+kFw7yfILvMvAVPsCDMC4urFBBC8Amw90xOg4isjdcJZV56n6Ohb38f8pdtgYXUsLA 0fwAeb6Zr4vzJq4MAKHytDcPIyitZL0Nyv5nRl9uULXsiLU9Gs4x5x/vFl25s2N1NDyEcscGIyj CHs9celcnuQHTrve01G3+6APPY295CHg9FLY29dA9zmrn8+vzERqK4GkF5IWxFYEwhcv2k1nB8w XI+LMnqGiVLzy1fHe4EtNC/WGz2R2qJnHOKdODZHn8CDQ== --nextPart15345406.uLZWGnKmhe Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1" From: Alexander Stein Date: Wed, 04 Mar 2026 15:14:55 +0100 Message-ID: <3640054.irdbgypaU6@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20251014061309.283468-1-alexander.stein@ew.tq-group.com> References: <20251014061309.283468-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Am Dienstag, 14. Oktober 2025, 08:13:08 CET schrieb Alexander Stein: > devm_regmap_init_mmio returns an ERR_PTR() upon error, not NULL. > Fix the error check and also fix the error message. Use the error code > from ERR_PTR() instead of the wrong value in ret. >=20 > Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver") > Signed-off-by: Alexander Stein Ping, any feedback? Thanks Alexander > --- > drivers/dma/xilinx/xdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c > index 3d9e92bbc9bb0..c5fe69b98f61d 100644 > --- a/drivers/dma/xilinx/xdma.c > +++ b/drivers/dma/xilinx/xdma.c > @@ -1325,8 +1325,8 @@ static int xdma_probe(struct platform_device *pdev) > =20 > xdev->rmap =3D devm_regmap_init_mmio(&pdev->dev, reg_base, > &xdma_regmap_config); > - if (!xdev->rmap) { > - xdma_err(xdev, "config regmap failed: %d", ret); > + if (IS_ERR(xdev->rmap)) { > + xdma_err(xdev, "config regmap failed: %pe", xdev->rmap); > goto failed; > } > INIT_LIST_HEAD(&xdev->dma_dev.channels); >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ --nextPart15345406.uLZWGnKmhe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEByESxqszIvkmWRwbaS+g2M0Z/iUFAmmoPl8ACgkQaS+g2M0Z /iU+vAgAhVn/PEgWR46nYGIDjXs2WVYaZ0jy+MzJwSpGsh+jaFAzTvUpHE16Uc+1 UYxIMMl0imWI1gGkg1woWnlr/9sHrleN8tAq+cXWZbC7dwaaOonIxJxI5bUvSXPq +O7zYQmMYhP6JuzCpiM8q5WkbYUX0EanSx/OrSpCdVID6Daw5C/kmEGPdN0YNvMY fIIE9wijsqrebamhTMsztxaQkBIcZagLCPq7+EfMDlvbKkQnDZdkWqijKqO3HpZe jOsrYjvi0J7/5gwNl34FHAxYKuxG0YObJLjeGIryMAFGfxppTqmjQNT+XCSIjWX5 pRhqhNyqrTlwekwdXcynMNnVfVEi0w== =tJUS -----END PGP SIGNATURE----- --nextPart15345406.uLZWGnKmhe--