From: Randy Dunlap <rd.dunlab@gmail.com>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Cc: "Biju Das" <biju.das.jz@bp.renesas.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
Date: Tue, 18 Jul 2023 07:39:39 -0700 [thread overview]
Message-ID: <364507a5-ea2e-6280-cc9e-394e09d6edf7@gmail.com> (raw)
In-Reply-To: <TYWPR01MB877550F95CF000B63E9AD022C238A@TYWPR01MB8775.jpnprd01.prod.outlook.com>
On 7/18/23 05:13, Fabrizio Castro wrote:
> Hi Randy,
>
>> From: Randy Dunlap <rd.dunlab@gmail.com>
>> Subject: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
>>
>> From: Randy Dunlap <rd.dunlab@gmail.com>
>>
>> When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build
>> errors:
>>
>>
>> Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is
>> still allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being built
>> but also allow the latter not to be built.
>>
>> drivers/pwm/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -505,7 +505,8 @@ config PWM_ROCKCHIP
>>
>> config PWM_RZ_MTU3
>> tristate "Renesas RZ/G2L MTU3a PWM Timer support"
>> - depends on RZ_MTU3 || COMPILE_TEST
>> + depends on COMPILE_TEST
>> + depends on RZ_MTU3 || RZ_MTU3=n
>
> Isn't this a tautology?
Not at all. It's used in Kconfig quite a bit.
This is tristate logic.
It says that if RZ_MTU3 is y/m, PWM_RZ_MTU3 is limited by that.
But if RZ_MTU3 is n, PWM_RZ_MTU3 can be y or m.
Is that clearer?
--
~Randy
next prev parent reply other threads:[~2023-07-18 14:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 6:41 [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors Randy Dunlap
2023-07-18 9:03 ` Uwe Kleine-König
2023-07-18 11:26 ` Biju Das
2023-07-18 11:43 ` Thierry Reding
2023-07-18 12:07 ` Biju Das
2023-07-18 12:05 ` Geert Uytterhoeven
2023-07-18 13:24 ` Thierry Reding
2023-07-18 16:57 ` Uwe Kleine-König
2023-07-19 7:40 ` Thierry Reding
2023-07-19 10:13 ` Uwe Kleine-König
2023-07-19 10:18 ` Biju Das
2023-07-19 10:20 ` Geert Uytterhoeven
2023-07-18 12:13 ` Fabrizio Castro
2023-07-18 14:39 ` Randy Dunlap [this message]
2023-07-18 15:07 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364507a5-ea2e-6280-cc9e-394e09d6edf7@gmail.com \
--to=rd.dunlab@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox