From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756178AbcBPVVw (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 16:21:52 -0500
Received: from mout.kundenserver.de ([212.227.126.130]:61553 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756156AbcBPVVs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 16:21:48 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        arm@kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Jonathan Corbet <corbet@lwn.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org,
        Tejun Heo <tj@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org, Lior Amsalem <alior@marvell.com>,
        Nadav Haklai <nadavh@marvell.com>, Omri Itach <omrii@marvell.com>,
        Wilson Ding <dingwei@marvell.com>
Subject: Re: [PATCH v4 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port
Date: Tue, 16 Feb 2016 22:20:51 +0100
Message-ID: <3647094.zzYms58VAY@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1455646502-23834-4-git-send-email-gregory.clement@free-electrons.com>
References: <1455646502-23834-1-git-send-email-gregory.clement@free-electrons.com> <1455646502-23834-4-git-send-email-gregory.clement@free-electrons.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:xulTO/0GvTcog4sDs3anjsa99NEuK8psE88NY5CuzIwKMRLyiBm
 l1LsRZuVu08jUjf3IFFXxljnjWW07/XFXZEnyAMDq5/ymQArWoQxaoh+QvhKI/T/TOUlUUA
 mfUJAotzTBeXvyOfS1ZQaEjKQp8LtayOZvr27t70vOXKB9SOrqguAHdMvUiKrr7fCFeotLB
 NVMuDUbGlussCkARVG+2Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:WkZP8R4yWAs=:pjG2qV58Ya5oVZZXiVdYhs
 ohkL1ZCfIvX7e2/t1Ok5QSzreHJxPMeHeSGIdUhwqvKSpDZqNbFyfOcL5HLiVkE3stuiRfqoV
 GZuE9wyP8lBd6c/YYnKv0MqMQP2LY53r9vIR0OjfJP5LEjl2afl5SmorF2DRCzqSQcumIEcpz
 9jEFqNfn6O8E3VdyyMoS0fNNfdhteblKLvSezRW8pmhlfIEs3XV5mg3zEyG1f8ZfY99lUemVy
 CTNFVk0F5lGsQ3UliN3Q4/7ax4n+Egyyjya1VvqvkELStKN3W/p8LekJITkWGFbEp+ryawajz
 3u+32BuEUWZIP+UEnXI0k1fKRdIy9pLcEWAta0LExsAjs5tZpmq0gtnYTXIMVtPscGyrQW6RH
 LIWIpsNJuTxmf3IN6ttwFEDMeuLQoVP5LgHy97YrEKFzAvKJInU1ese3enXh4zreFplWt4t6Q
 f8XhEmegNSxkCdNVELrccdMIfV8tTJWGJ3eKMnt+EsQmxG66vgC5cAiFqkdRN3AjH5zxyRWlJ
 1PaWjypxul7r9DV4v91atBTshO9J2Qm9URcymGc+m+cAuiqq/wy/c4G2Pro/X5TkgNJJC1JBI
 YtumCeXNI/ZrXxCJz3G9Ahge3OSGETI5EZVoVggsUmnL7Q9we9L8hFUBM3nP4ruhRmJwbZ9U8
 4JZ82R1t/lkhvptDXIwS0nDzQaM8zdallpETaLeQxLpLx+btOooM0odDLN8UC7WGxmXSex9bf
 WBsTFEPoSGS9PE+l
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 16 February 2016 19:14:53 Gregory CLEMENT wrote:
> 
> +config SERIAL_MVEBU_UART
> +       bool "Marvell EBU serial port support"
> +       select SERIAL_CORE

It would be nice to make this a tristate option with

	depends on ARCH_MVEBU || COMPILE_TEST

so we can build it in an allmodconfig kernel as a standalone module
like the other drivers.

> +
> +config SERIAL_MVEBU_CONSOLE
> +       bool "Console on Marvell EBU serial port"
> +       depends on SERIAL_MVEBU_UART

then this one must become

	depends on SERIAL_MVEBU_UART

so it does not get enabled if the driver is not builtin.

	Arnd