From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF7032D450 for ; Mon, 24 Nov 2025 19:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764014069; cv=none; b=ZvRNtOTQZ458S9QLnMsAxeFmvBauSXcpTL9NG+M6JiZ4IGDYGnzb8qCLYygNFoosUiqwAbFDECsGWRopWAc6QmlaoGCC/a/U5jdOfejSbScQ6GZwmTtLmtXA/D6fBX/0A7QsvnIyiaqUbJ9FfD+XxiG+YpNkgCO1oFBbc+QE1co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764014069; c=relaxed/simple; bh=Zm+q+l9qQx8Bba+OEMBC0euPoac6H638UyyPFc8BJZU=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=V+rkgHn5DpuApGrJ9MVEzmqefe8nKMKUb+kLmlMtzE6aSbZ7BVMeXRzXmYE7HAtVaCAQhNfdTYLtO5MlY8zmZMTlzzRLjBG6E7TSdg7otED5urf92OaHeB7o3VzDDXwhoVM7W9Da7WZ7n1DAzW6uILCFB1mzgIeJJBSNi9MxGE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WMHYy1gK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WMHYy1gK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764014066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QkcIAl5r3oTz2YJkwOodI54A9txsGksKR1/Qewobb2Y=; b=WMHYy1gKif3FMGS4ADE2TkDqY/B1UifVBxwLGPjHKIgnI+l2SNmSeG1PPYwoSQdVpJlibv JpvuiGYy5tiaO1QYIWIsb92QZSA40AwhHJmoFRkdl2/+0izIx7TGBski0sztBiTZ00bnQV hlr8Czw6fUHO0IZc3ELjoBadGkEta6o= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-yADlOeZVMRSrgKh98eLfEw-1; Mon, 24 Nov 2025 14:54:22 -0500 X-MC-Unique: yADlOeZVMRSrgKh98eLfEw-1 X-Mimecast-MFC-AGG-ID: yADlOeZVMRSrgKh98eLfEw_1764014059 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1B34C18001D1; Mon, 24 Nov 2025 19:54:19 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.14]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2C433195608E; Mon, 24 Nov 2025 19:54:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20251120104439.2620205-6-dhowells@redhat.com> <20251120104439.2620205-1-dhowells@redhat.com> <3374841.1763975577@warthog.procyon.org.uk> <20251124164914.GA6186@sol> <3647621.1764005088@warthog.procyon.org.uk> To: "Jason A. Donenfeld" Cc: dhowells@redhat.com, Eric Biggers , Herbert Xu , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Ard Biesheuvel , Stephan Mueller , Lukas Wunner , Ignat Korchagin , linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 5/8] crypto: Add ML-DSA crypto_sig support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3649784.1764014053.1@warthog.procyon.org.uk> Date: Mon, 24 Nov 2025 19:54:13 +0000 Message-ID: <3649785.1764014053@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Jason A. Donenfeld wrote: > > > Still not really sure what the point is. There's only one user of > > > crypto_sig, and it could just call the ML-DSA functions directly. > > > > Is it your aim to kill off the crypto/ dir and all the (old) crypto API? > > Probably entirely killing off the old API is going to be fraught > because its abstraction has leaked out to userspace. But to the extent > we can minimize its use over time, I think that's a good thing. Even > for crypto usages that generalize to a few different ciphers of one > variety or another, I think being explicit about which ciphers and > having purpose-built dispatchers is usually a better route. How are you proposing handling the autoloading feature of the old API? David