Re: [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5

Sibi Sankar
2018-12-18T05:52:49Z

Hi Doug,
Thanks for the review :)

On 2018-12-18 05:29, Doug Anderson wrote:
> Hi,
>
> On Mon, Dec 17, 2018 at 2:07 AM Sibi Sankar <sibis@codeaurora.org>
> wrote:
>>
>> Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 10
>> +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> Fixes: 9f058fa2efb1 ("remoteproc: qcom: Add support for mss remoteproc
> on msm8996")
> Fixes: fb22022ff63d ("dt-bindings: remoteproc: Add Q6v5 Modem PIL
> binding for SDM845")
>
> ...it probably doesn't matter too much but if we wanted to be really
> careful we could split into two patches, one for the msm8996 and one
> for sdm845. I don't think people care that much about stable
> backports of bindings though (someone can feel free to correct me)...
>

I did think of splitting this up but it doesn't
actually fix 9f058fa2efb1 yet. I noticed a few missing
clocks for mss on 8996 when I did a diff with the
corresponding CAF tree. Hence couldn't add bindings for
it. Will add them once I validate mss on 8996 with the
necessary changes.

>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> index 9ff5b0309417..780adc043b37 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> @@ -39,13 +39,17 @@ on the Qualcomm Hexagon core.
>> - clocks:
>> Usage: required
>> Value type: <phandle>
>> - Definition: reference to the iface, bus and mem clocks to be
>> held on
>> - behalf of the booting of the Hexagon core
>> + Definition: reference to the list of 4 clocks for the modem
>> sub-system
>> + reference to the list of 8 clocks for the modem
>> sub-system
>> + on SDM845 SoCs
>
> The above is confusing because you don't list the SoCs that are
> supposed to use the 4 clocks. How about instead:
>
> Definition: reference to the clocks that match clock-names
>

AFAIK, only the exceptions are captured. I am fine
with both, I'll wait for Bjorn/Rob's preference.

>
>> - clock-names:
>> Usage: required
>> Value type: <stringlist>
>> - Definition: must be "iface", "bus", "mem"
>> + Definition: must be "iface", "bus", "mem", "xo" for the modem
>> sub-system
>> + must be "iface", "bus", "mem", "gpll0_mss",
>> "snoc_axi",
>> + "mnoc_axi", "prng", "xo" for the modem sub-system
>> on SDM845
>> + SoCs
>
> Same here where it's confusing. ...but also, it it correct? As far
> as I can tell you're missing msm8996. It's better to just be explicit
> and list each one, ideally without all the prose.
>
> Definition: The clocks needed depend on the compatible string:
>

ditto

> qcom,sdm845-mss-pil: "xo", "prng", "iface", "snoc_axi", "bus", "mem",
> "gpll0_mss", "mnoc_axi"
> qcom,msm8996-mss-pil: "xo", "pnoc", "iface", "bus", "mem",
> "gpll0_mss_clk"

ditto

> qcom,msm8974-mss-pil: "xo", "iface", "bus", "mem"
> qcom,msm8916-mss-pil: "xo", "iface", "bus", "mem"
> qcom,q6v5-pil: "xo", "iface", "bus", "mem"
>
> ...as far as I can tell this binding is supposed to account for
> "qcom,ipq8074-wcss-pil" too but it seems that one doesn't have
> clock-names.
>

Yeah the lack of clocks have to be documented
for ipq8074-wcss-pil.. will do it in v3

>
> -Doug

--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.