From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752492AbcAELqv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 06:46:51 -0500
Received: from mout.kundenserver.de ([212.227.126.130]:52043 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752423AbcAELqm convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 06:46:42 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Pali =?ISO-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
        Laura Abbott <lauraa@codeaurora.org>, Tony Lindgren <tony@atomide.com>,
        Sebastian Reichel <sre@debian.org>, Will Deacon <will.deacon@arm.com>,
        linux-kernel@vger.kernel.org,
        Devicetree Spec List <devicetree-spec@vger.kernel.org>,
        Rob Herring <robherring2@gmail.com>, Pavel Machek <pavel@ucw.cz>,
        Grant Likely <grant.likely@linaro.org>,
        Russell King <linux@arm.linux.org.uk>, linux-omap@vger.kernel.org,
        frowand.list@gmail.com,
        Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Subject: Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision"
Date: Tue, 05 Jan 2016 12:45:52 +0100
Message-ID: <3663322.UyrB2OmX6o@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20160105113750.GL22661@pali>
References: <1436214373-12969-1-git-send-email-pali.rohar@gmail.com> <50067860.qzAxcgo8L4@wuerfel> <20160105113750.GL22661@pali>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
X-Provags-ID: V03:K0:aRQTgmJw4mU0E/XlAnnB6peXE2jRRKi2K9ffDqchoQcmnqEhFDC
 MjkmZj0sYesPrw9AdtXyDlWMOgZyzaCITaV2rGerjBNm1buxFQxNi77HbTbT6SAwaNJGqJX
 g06XTRkA8CHtMQNEnhkxG5BkzTpS6TPsZIUlwfBQE0qiDSPwnCU3kWQf51Hb9M6MHHAi5FM
 UaYrSJsuwekTGfCs6G5PA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:hsnU86llVqk=:ir27WVHM4K4Z7ilc9rpFbH
 xBgaLNep/o/r/nXTBRgEr2AfrIeG0w9xTAaVdfWd46NYUy0YIBVDbdsy29WcbzaC0295CCAV+
 Q9zYb5IkjnBvrR8FA6skBDWy9r7CPvn83W5bQUDotSRjm/xqpJLWMbw579AruQj5zHo+gNSyt
 1mWa1KBXiWsdRhb8/VXf/oct76qmnnbiiNiZGPJ7DfSiRgS83K12/0CpuiEmNGln6fMiPFTm2
 UtNBNqZjXAIA4u4KSFWBGBqEO9xjYIKixVf576A7acJIwWIYCoe/nR0loa7iwWwFHAL88Sf22
 9zS1A9EB0SgSCP8D7mVQYWrbQAUVkF0JYll1/y12GJDGJMOi8wOyVpToUUuQc0RsqMHBKwX/z
 58Sm8+jmK/r6C0DA+K2C2OBDa9Rs9ZXXwQsZlKQwqEXYzDR52Zd+TkR63uace9t6Q6MlyY6sF
 oRBpkZ5NKxe08RvPsDEJ9fEAD/q6NzFCFAkSRelfNxOPLBtaaduW/ELSqrldcr95m7TCWeoiN
 HGl4YeXE5m+yiXhIFEX/+fNXSnF4ywh58l1cBCOr6bnIdL/onXuRbQzmIoCg+r1dsojhI8wHQ
 KmnTqxQbdov01KkML1RtnzGH5okygpXVONJjaIH6pJodAu9Ss5jLabYHBGyPBlW9NIHzpCcr2
 9JH/9tRUVBImgTbFgd1kaf4rKtPomtSic4q5okRWdcBX2QOdYWqC08TwAmuDv21DXJZbFTxK7
 u44dtz/r+5WKALyS
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 05 January 2016 12:37:50 Pali Rohár wrote:
> On Monday 28 December 2015 23:27:17 Arnd Bergmann wrote:
> > On Monday 28 December 2015 13:01:22 Frank Rowand wrote:
> > > 
> > > Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revision"
> > > property.
> > > 
> > > If the use of /revision is limited to being a location to hold an ATAG
> > > value to pass to the global variable system_rev, then it would make
> > > sense to just copy directly from the ATAG value into system_rev in the
> > > same board file where you are copying the ATAGs.
> > 
> > Agreed. That would be simpler, and avoid a situation where someone relies
> > on the /revision property in DT to be set from the atags compat code
> > (preventing an upgrade to a newer bootloader), or on the system_rev variable
> > to be the same across multiple boot loaders, in the absence of other
> > kernel code setting it.
> 
> So, set system_rev only for Nokia N900? At same place where is called
> save_atags()?
> 
> 

Yes.

	Arnd