From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>,
Shaun Tancheff <shaun@tancheff.com>
Cc: linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>,
Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
Mike Christie <mchristi@redhat.com>
Subject: Re: Fixup direct bi_rw modifiers
Date: Mon, 1 Aug 2016 09:17:50 -0600 [thread overview]
Message-ID: <36734f69-33f5-c2fd-67da-d2d867741403@kernel.dk> (raw)
In-Reply-To: <20160801114713.GA16806@infradead.org>
On 08/01/2016 05:47 AM, Christoph Hellwig wrote:
> On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote:
>> bi_rw should be using bio_set_op_attrs to set bi_rw.
>
> Looks fine,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Added, thanks Shaun.
> Jens,
>
> what do you think about renaming bi_rw? There aren't too many users
> left, and any old code that would keep using it is alsmost guranteed
> to be broken, so sending a post-rc1 patch to rename it might make
> everyone else life easier. Especially as it's also grossly misnamed
> now.
I was planning on doing that, after -rc1. Much better to get build
breakage, than potentially much worse breakage.
--
Jens Axboe
next prev parent reply other threads:[~2016-08-01 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 21:45 Fixup direct bi_rw modifiers Shaun Tancheff
2016-08-01 11:47 ` Christoph Hellwig
2016-08-01 15:17 ` Jens Axboe [this message]
2016-08-01 19:55 ` Jens Axboe
2016-08-02 12:32 ` Christoph Hellwig
2016-08-02 18:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36734f69-33f5-c2fd-67da-d2d867741403@kernel.dk \
--to=axboe@kernel.dk \
--cc=axboe@fb.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=shaun@tancheff.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox