From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbcHAPXt (ORCPT ); Mon, 1 Aug 2016 11:23:49 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:37044 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbcHAPXi (ORCPT ); Mon, 1 Aug 2016 11:23:38 -0400 Subject: Re: Fixup direct bi_rw modifiers To: Christoph Hellwig , Shaun Tancheff References: <1469915148-20452-1-git-send-email-shaun@tancheff.com> <20160801114713.GA16806@infradead.org> Cc: linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Chris Mason , Josef Bacik , David Sterba , Mike Christie From: Jens Axboe Message-ID: <36734f69-33f5-c2fd-67da-d2d867741403@kernel.dk> Date: Mon, 1 Aug 2016 09:17:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160801114713.GA16806@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2016 05:47 AM, Christoph Hellwig wrote: > On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote: >> bi_rw should be using bio_set_op_attrs to set bi_rw. > > Looks fine, > > Reviewed-by: Christoph Hellwig Added, thanks Shaun. > Jens, > > what do you think about renaming bi_rw? There aren't too many users > left, and any old code that would keep using it is alsmost guranteed > to be broken, so sending a post-rc1 patch to rename it might make > everyone else life easier. Especially as it's also grossly misnamed > now. I was planning on doing that, after -rc1. Much better to get build breakage, than potentially much worse breakage. -- Jens Axboe