From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52CA92FB965 for ; Sun, 19 Apr 2026 22:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776638308; cv=none; b=BeTC6N+aWI+JEV6OY1M3k2tZbKalY9wQRhJrBz3S5qZ/YeGzf8tBX0Vimwnr43yRqW76kUWBs1CRZ9oWiE3E+4JdDXEekVn1Y6Z+CVnnnfsEcdNTyQ4gQqNn5cQQfN1+pWl9OKP0s6PFpAIlJtSia0Dzno+KvcHETEA9+dnz9RU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776638308; c=relaxed/simple; bh=FUdqs8G4xwhD/VXXAjrPpZWDZq3wYXxHJeq5QFisxbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bycmNwdKrhsDNP7LxoVG0AwKY0mjyCqAGFk9KUPrPwelcwUJ2xRANI5G30SfHkSowOw++7IJR0befSBgsZOljhS4VaYiC9zrf8gib5vYyGw+h42PEprcUJ+Oz89u/TCjZicy4Z1BfwxE8cmSJ36/+aisXJcCueZjvnMZgXAanKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p2XFwuer; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p2XFwuer" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7dbba5076c8so1300369a34.0 for ; Sun, 19 Apr 2026 15:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776638306; x=1777243106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yeLIlLS6xhhKIOicu0WwjZofN4fneA1R4+99jdOi6J8=; b=p2XFwuerkqqQtesQvOPuW5A/cqIFi0kzEjEtuZdO0zqevgOVjO2JJ7mN70pzKnpeM6 E6OysWeXhiHUAFIQK+3C1j7mysDk5hTO3YbRqDRjr3uybiHI830ldxgAzcirix2Wqc6Z uD9QpZdnTkaO9d137jzl7Bnrl3XRQPPi71jVcKo23LR3gYUvJ7yaBgRAZyAAQRZZk47b gFgXV8AIEpDdPvL/JCwkbP1lNzfFV6waLfUg4sW7f5224qO1z5JCyU1N6Em/VvdvDb3a RhejPa0qe9W6BBNLc9JyNKGWxuhGdyU4RDjfQv5tadxFmV+t1jm/5uTmo2jDxBwl/mgy /XUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776638306; x=1777243106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yeLIlLS6xhhKIOicu0WwjZofN4fneA1R4+99jdOi6J8=; b=f2uzTLoy4NfNtD9vszHXy5VH7iDi7DsVX36z+VM3Ii7QWTchauTZIXbfzby44sRaQS itWjnMLq/h3Tn9GNFikjawLqcMpS7VvAw3SgL9Lw2FRBjEiU4kkGhQthplveMpsUQEIC nwE/6AR1dfX6YvVT2rsrVO3bviPWQmtJ/GSy86EZoF+Hz/fu7zBxIQ1u2qeR5kpSHbe5 ia+vFPTx43/C5geX6dGGS3cD4+MaaQ+Gxn95BUhf+C0Tqdo5JlNNDbsgk7iREPdKzHEN R88A01zRIGWfO1OM5lMKzu/mhctbaeDDHq53SVI8Y4SdRFoBvJRd9RbQn1zreoDl1NkR I7pA== X-Forwarded-Encrypted: i=1; AFNElJ9g53hk1UMOywZJtzlzve95aEyJ6hqGeiyzJuWYn1EQ7ubi2zQkg3F/2BuW611sYR/yi6YuO3W2sAhCXqk=@vger.kernel.org X-Gm-Message-State: AOJu0YwBJMiHj4m4cZsKLejM2pD8tm356ym4Uxszj3X809PgF3OCvCgo HnpHQBlvOCdJtKTlyA7eDiV1FalCaLWGlYIzYZuKXb8zWra85NisqHAm X-Gm-Gg: AeBDievImSx4ncHcqaSX3+Xr0eLdqz1vMmT/qcD1pgO3k9QS/+DJGOx4gLlZ3bAbA7Y UfWmtuMsp5yANVWaQuhWp7wn+u/e+MML/N1s2vg+KvKncbrQI7OUvT3/rtePxfJnpgxuO4MSSyw o6DiIcwicxFs6LrBlE2TasmYOf7qW2iICPNaUd4DW22221RIBBjuw9qln8lxnEczesJ4NqbMfw1 LA7+dQBTBpOnt9jBG83jKRPyx0FB7eQY/bzsV8kiPT1IkqY3RZwEJbPTrEi12mOBZHtJtM2rhs3 iIMTkn+g+3bcX8FRAno3vTyBcV/GzN5obp/IenQMA+pOjnG94aISqXXnvMk6UMoHgVDO88y3XCE wP+UvAD5+dRphaZ0AgwQxzh5BgmBlyp4Ox0WlI9IsEubK+7a0EvMnfZt6f/aGdBzAT30UUjcOOv 8Iv0BOuUVrI+xmBF9g+WDbwxBGT7JLNXISyG+MoeRJmbd63SIR6ksL83SPbIV8p2N0nVvWf9yf9 K6iAbPwlORMITGt77CxSiqSvkhelgkkkfm7X49TR14/7EctL/JVnLLIvkM= X-Received: by 2002:a05:6830:411a:b0:7d7:d2e4:6373 with SMTP id 46e09a7af769-7dc951fb364mr7104813a34.20.1776638306240; Sun, 19 Apr 2026 15:38:26 -0700 (PDT) Received: from nukework.gtech (c-98-34-199-138.hsd1.tx.comcast.net. [98.34.199.138]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dc975b057bsm7891589a34.20.2026.04.19.15.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 15:38:25 -0700 (PDT) From: "Alex G." To: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan Cc: sumit.garg@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, Varadarajan Narayanan , Konrad Dybcio Subject: Re: [PATCH v4 1/4] arm64: dts: qcom: ipq9574: Add gpio details for eMMC Date: Sun, 19 Apr 2026 17:38:24 -0500 Message-ID: <3675281.vFx2qVVIhK@nukework.gtech> In-Reply-To: <20260202073322.259534-2-varadarajan.narayanan@oss.qualcomm.com> References: <20260202073322.259534-1-varadarajan.narayanan@oss.qualcomm.com> <20260202073322.259534-2-varadarajan.narayanan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Monday, February 2, 2026 1:33:19=E2=80=AFAM Central Daylight Time Varada= rajan=20 Narayanan wrote: Hi Varadarajan, > The RDP433 has NAND and eMMC variants. Presently, only NAND variant is > supported. To enable support for eMMC variant, add the relevant GPIO > related information. >=20 > Do not enable NAND by default here. Enable it in board specific DTS. >=20 This commit references sdc_default_state in the .dtsi file, without definin= g it.=20 It creates a silent dependency on the board .dts, who must now define the p= ins.=20 This makes no sense to me for boards that don't have eMMC. As an example, i= t=20 breaks most downstream OpenWRT boards. Was this new dependency accidental? Alex > Reviewed-by: Konrad Dybcio > Signed-off-by: Varadarajan Narayanan > --- > v4: Move sdhc properties from emmc dts to SoC dtsi >=20 > v3: Disable nand in ipq9574-rdp-common.dtsi and enable it where required. > Add 'Reviewed-by: Konrad Dybcio' > --- > .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 32 +++++++++++++++++++ > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 9 ++++++ > 2 files changed, 41 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi index > bdb396afb992..e4ae79b2fcd9 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > @@ -169,6 +169,38 @@ data-pins { > bias-disable; > }; > }; > + > + sdc_default_state: sdc-default-state { > + clk-pins { > + pins =3D "gpio5"; > + function =3D "sdc_clk"; > + drive-strength =3D <8>; > + bias-disable; > + }; > + > + cmd-pins { > + pins =3D "gpio4"; > + function =3D "sdc_cmd"; > + drive-strength =3D <8>; > + bias-pull-up; > + }; > + > + data-pins { > + pins =3D "gpio0", "gpio1", "gpio2", > + "gpio3", "gpio6", "gpio7", > + "gpio8", "gpio9"; > + function =3D "sdc_data"; > + drive-strength =3D <8>; > + bias-pull-up; > + }; > + > + rclk-pins { > + pins =3D "gpio10"; > + function =3D "sdc_rclk"; > + drive-strength =3D <8>; > + bias-pull-down; > + }; > + }; > }; >=20 > &qpic_bam { > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > b/arch/arm64/boot/dts/qcom/ipq9574.dtsi index 86c9cb9fffc9..4b8c58982869 > 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -467,6 +467,15 @@ sdhc_1: mmc@7804000 { > clock-names =3D "iface", "core", "xo", "ice"; > non-removable; > supports-cqe; > + pinctrl-0 =3D <&sdc_default_state>; > + pinctrl-names =3D "default"; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + mmc-hs400-enhanced-strobe; > + max-frequency =3D <384000000>; > + bus-width =3D <8>; > + > status =3D "disabled"; > };