Re: [PATCH] kgdb: more barrier in blank weak function

Ingo Molnar
2008-12-27T08:18:32Z

* Yinghai Lu <yinghai@kernel.org> wrote:

> Impact: fix panic possible panic etc
>
> some compiler seems to inline the weak global function if no line in it

> kgdb_post_primary_code(struct pt_regs *regs, int e_vector, int err_code)
> {
> - return;
> + barrier();
> }

> void __weak kgdb_disable_hw_debug(struct pt_regs *regs)
> {
> + barrier();
> }

seems like the barrier() is not enough - the only safe sequence seems to
be to turn it into a function that returns an integer.

Ingo