Re: [PATCH 1/2] s390: fgraph: Fix to remove ftrace_test_recursion_trylock()

Ihor Solodrai
2025-01-29T00:36:49Z

January 28, 2025 at 7:29 AM, "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:

>
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Fix to remove ftrace_test_recursion_trylock() from ftrace_graph_func()
>
> because commit d576aec24df9 ("fgraph: Get ftrace recursion lock in
>
> function_graph_enter") has been moved it to function_graph_enter_regs()
>
> already.
>
> Reported-by: Jiri Olsa <olsajiri@gmail.com>
>
> Closes: https://lore.kernel.org/all/Z5O0shrdgeExZ2kF@krava/
>
> Fixes: d576aec24df9 ("fgraph: Get ftrace recursion lock in function_graph_enter")
>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Tested-by: Jiri Olsa <jolsa@kernel.org>
>
> [...]

Hi Masami,

Can confirm this patch fixes missed/kprobe_recursion BPF selftests on s390x:
https://github.com/kernel-patches/vmtest/actions/runs/13021621468/job/36324248903

Tested-by: Ihor Solodrai <ihor.solodrai@linux.dev>

Thanks!