From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f100.google.com (mail-pj1-f100.google.com [209.85.216.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CCFF37187B for ; Wed, 5 Aug 2026 06:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909922; cv=none; b=uJjIvED1n2dBNhqdooFUwuxGBp7WHltp41NZH0hBMq1pMHN4pzOS/lfKptq1UXM7ikgf1Z5Gga4I38wSYcZg6V9cWxQszbyC7hXJKrYo09MORUVAWAY//zNpvLVBeGEhrOOazPXxUxVDZE9/J2dwHE53RAemHqUlLyemIXETfMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785909922; c=relaxed/simple; bh=OriPhg6YGIwEW9hmmH46YSgFHuBbRMq19BdArA9MZD0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WpEFmFp9IyVQMYx7t2r2Tsevm67o7NFgzZyuliiYnx2xx3lNnsHsAfu0bV+WRFC0RCt5FxV8/+xazxLX0fjo3LXrcITXdu/phDMagzKCYdXbgWzI5GBlkHKSBt9dHoa0oDQkpHggFZojUzGP0lPRZuIvPWSBnu3Uj5IyCMph7FM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=f+ow04oh; arc=none smtp.client-ip=209.85.216.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="f+ow04oh" Received: by mail-pj1-f100.google.com with SMTP id 98e67ed59e1d1-38de840f2f0so462296a91.0 for ; Tue, 04 Aug 2026 23:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785909920; x=1786514720; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=ixvJyzHf6CwQR78Vnc98OrtjL5Qm3qHKniNH1npgOPE=; b=U/7dkrdylT1DpiOReMmJCbYiElJwseTVvBBAgM40hoKy2L0Zt2yIeF8hZwH8vTiYal 9D+M7XOKPblYbkx4Pak/OslL0LmR7SwZU2cRRGaOOQDzMjEjR8oUm04vo+nzsXJjUSgj Al1yrs39mDcgntgvfnssVP4peoKiORjzqdIAId5AueK9/AdxhT/1dqEu6tOigUaZDJrG jeAv5jRt6YU7YVVZ5f1f4hjiLosMrw45JPeuC0rFYGabNpj3DnJL6eEKNk9QgHMYfQYR VH2M5hsaquKSD2uuKYoD7kw2QVSD/377eqQ7BsGktH/ezU/s8V7siv5u9qv+cosbt6lC sYpw== X-Forwarded-Encrypted: i=1; AHgh+RolzDilfZkWq7WQlvFX4Naw13J5eAPT6qfdWcYgMyq2J7e34ujU4/o1tgXYuufcA8UW1cWWpX0v7koNzU8=@vger.kernel.org X-Gm-Message-State: AOJu0YzI15u6E2nRfszaee/wXploohbYfrCJPss/yoAxjoZFNs9eSp7i mBB89/80EVGzmTFIcJQejD+yNB/oKfTeZKkuyJUBVCEISN8rv80xQo0GbNR3l/d2j86/dT2Icng JkPmkkYhc/yB12RNS18+lZUhCMkEoOyJRgdmouwpnTN3i5e3pMUGt+3mUkLPuG1ZFNAaPuIxE3j tBp++ks1iCAfoez0r1MP5S3+f5FPWincrpeqnKwo6CCFnMxXAoJVXS2ahqyOMMHSA43zAK3VJky 31EtnHsy4ia5HwjIcNqEFZR5w== X-Gm-Gg: AR+sD12R+6U6By4cXlJuXUQOhOk886GioEBie8PyjFhD0kdIQonM5udmFiaGVaQ1M9h G40RriUSTpdWj5J49Iu4Lf3OyLplPChXqtX8Hl49RcI55Ylrj1SpHNWYjIwTQWpsGksNwn0aOrA v1AawqrpGTSSKbxtYDys2hkuqUUuwZDzsf0C3F1lM5MHI1ktFLsQCKW8ZjAHpmjKoAP9R9SLMdi 4WWXFpAaoGkKsVzG14XqXOChb0K0Q/CxIIxoKdmQXnFgqoUJiBul23LQhgv6Y78pJEDhCIN10m4 OwFAQDW9pM7QDVJGjmKB9nbu+klR+gRGW3FA7NJi39JEEFil5LxxXwrKUqNEe1t/QjyzL6DZgNj AOEZUmReNShvITlwsrG1e6ikj9HNiWLLs190g3zqNWD96Jgu+iNAhsgdce1nLZAgitnW560+QS4 JqCCiZDjaKZPWD7I6TnRRGuJ50haPBYt/f70pqE64= X-Received: by 2002:a17:90b:520a:b0:38f:efed:5445 with SMTP id 98e67ed59e1d1-3903c54adafmr4459838a91.4.1785909919559; Tue, 04 Aug 2026 23:05:19 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-38febe748f9sm819525a91.2.2026.08.04.23.05.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2026 23:05:19 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93494174477so52016285a.3 for ; Tue, 04 Aug 2026 23:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785909918; x=1786514718; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ixvJyzHf6CwQR78Vnc98OrtjL5Qm3qHKniNH1npgOPE=; b=f+ow04ohqJqfSxh3Rfm1dIJfTvahqicxT1Yjyj5VvMwcw1cO4JAYH80Q4AH8TekJY4 sU4VAqpVIiE9hJAneuomLOq4RtnCsOGWR/2GUXhuCPZpZ0sk3yAF3B87ONGnDYTuueMh Kne1tBHUVhW+nzHCMD/ztWxMnSsgR/S2dZLak= X-Forwarded-Encrypted: i=1; AHgh+RrmJAicMX18TCjIsTgJ8NJB3lPsMyJfUdhTtOCZxU8kUzJXdnvswwJ+KI0CbNEtH+sa+6cASiwJRcUPNxU=@vger.kernel.org X-Received: by 2002:a05:622a:a06:b0:51c:844f:28da with SMTP id d75a77b69052e-52ce5f8fa54mr48932051cf.5.1785909918286; Tue, 04 Aug 2026 23:05:18 -0700 (PDT) X-Received: by 2002:a05:622a:a06:b0:51c:844f:28da with SMTP id d75a77b69052e-52ce5f8fa54mr48931731cf.5.1785909917851; Tue, 04 Aug 2026 23:05:17 -0700 (PDT) Received: from [192.168.178.26] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52ce8975b3dsm12228941cf.30.2026.08.04.23.05.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 23:05:17 -0700 (PDT) Message-ID: <367ced51-be75-4e21-8e8f-6ed31331a0d2@broadcom.com> Date: Wed, 5 Aug 2026 08:05:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] wifi: brcmfmac: cyw: pass PMKID to firmware if present To: Bogdan Nicolae Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260804060859.412348-1-bogdan.nicolae@gmail.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260804060859.412348-1-bogdan.nicolae@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 04/08/2026 08:08, Bogdan Nicolae wrote: > Zero out auth_status on initialization. Otherwise, garbage will > leak from the stack to the firmware (when ssid is less than 32 bytes > and/or when params->pmkid is set). Then, pass the params->pmkid to the > firmware (without it, the firmware caches a garbage PMKID on successful > authentication and denies a subsequent association request that includes > the PMKID). > > Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode") > Signed-off-by: Bogdan Nicolae > Acked-by: Arend van Spriel The checkpatch results on patchwork still show one failure [1]. Regards, Arend [1] https://netdev-ctrl.bots.linux.dev/logview.html?f=/logs/build-wireless/1139831/14729070/checkpatch/stdout > --- > v4: Fixed indentation > v3: Added Fixes, Cc: stable, and Acked-by tags > v2: Split into a separate patch > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > index 873754be5..2c59b5e57 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > @@ -200,7 +200,7 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, > { > struct brcmf_if *ifp; > struct brcmf_pub *drvr; > - struct brcmf_auth_req_status_le auth_status; > + struct brcmf_auth_req_status_le auth_status = {}; > int ret = 0; > > brcmf_dbg(TRACE, "Enter\n"); > @@ -208,6 +208,8 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, > ifp = netdev_priv(dev); > drvr = ifp->drvr; > if (params->status == WLAN_STATUS_SUCCESS) { > + if (params->pmkid) > + memcpy(auth_status.pmkid, params->pmkid, WLAN_PMKID_LEN); The line above exceeds the 80 column limit. > auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS); > } else { > bphy_err(drvr, "External authentication failed: status=%d\n",