From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/18] thermal: exynos: set trips in ascending order in exynos7_tmu_initialize()
Date: Wed, 02 May 2018 11:37:08 +0200 [thread overview]
Message-ID: <3681690.4QzPMdFsyU@amdc3058> (raw)
In-Reply-To: <20180501100242.GJ27619@mai>
On Tuesday, May 01, 2018 12:02:42 PM Daniel Lezcano wrote:
> On Thu, Apr 26, 2018 at 01:51:28PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > Set trips in ascending order in exynos7_tmu_initialize() (it should
> > make no difference in driver operation). This prepares the driver
> > code to moving trips setting from ->tmu_initialize method to
> > exynos_tmu_initialize().
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> > drivers/thermal/samsung/exynos_tmu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> > index 12b60e2..571511f 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -618,7 +618,7 @@ static void exynos7_tmu_initialize(struct platform_device *pdev)
> > sanitize_temp_error(data, trim_info);
> >
> > /* Write temperature code for rising and falling threshold */
> > - for (i = (of_thermal_get_ntrips(tz) - 1); i >= 0; i--) {
> > + for (i = 0; i < of_thermal_get_ntrips(tz); i++) {
>
> Capped with data->ntrip ?
No need to, the code in question is removed in patch #14 (also Exynos7
DTS doesn't define more trip points than data->ntrip).
> > tz->ops->get_trip_temp(tz, i, &temp);
> > temp /= MCELSIUS;
> > exynos7_tmu_set_trip_temp(data, i, temp);
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2018-05-02 9:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180426115159epcas2p3b8d995ba552b403b5052f74970fdef0f@epcas2p3.samsung.com>
2018-04-26 11:51 ` [PATCH 00/18] thermal: exynos: further fixes and cleanups Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433 Bartlomiej Zolnierkiewicz
2018-04-30 14:36 ` Daniel Lezcano
2018-04-30 15:21 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 02/18] thermal: exynos: always check for trips points existence Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 03/18] thermal: exynos: always check for critical trip " Bartlomiej Zolnierkiewicz
2018-04-30 14:44 ` Daniel Lezcano
2018-04-30 15:24 ` Bartlomiej Zolnierkiewicz
2018-05-01 9:00 ` Daniel Lezcano
2018-05-02 9:16 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 04/18] thermal: exynos: check STATUS register in exynos_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 15:23 ` Daniel Lezcano
2018-04-26 11:51 ` [PATCH 05/18] thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 15:30 ` Daniel Lezcano
2018-04-26 11:51 ` [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg() Bartlomiej Zolnierkiewicz
2018-04-30 15:34 ` Daniel Lezcano
2018-04-30 15:48 ` Bartlomiej Zolnierkiewicz
2018-05-01 9:39 ` Daniel Lezcano
2018-05-02 9:19 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 07/18] thermal: exynos: remove threshold_code checking from exynos4210_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 15:37 ` Daniel Lezcano
2018-04-26 11:51 ` [PATCH 08/18] thermal: exynos: make ->tmu_initialize method void Bartlomiej Zolnierkiewicz
2018-04-30 15:40 ` Daniel Lezcano
2018-04-26 11:51 ` [PATCH 09/18] thermal: exynos: clear IRQs later in exynos4412_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 14:47 ` Daniel Lezcano
2018-04-26 11:51 ` [PATCH 10/18] thermal: exynos: move IRQs clearing to exynos_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-04-30 14:47 ` Daniel Lezcano
2018-05-06 23:27 ` Eduardo Valentin
2018-04-26 11:51 ` [PATCH 11/18] thermal: exynos: add exynos*_tmu_set_[trip,hyst]() helpers Bartlomiej Zolnierkiewicz
2018-05-01 9:55 ` Daniel Lezcano
2018-05-02 9:33 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 12/18] thermal: exynos: do not use trips structure directly in ->tmu_initialize Bartlomiej Zolnierkiewicz
2018-05-01 9:59 ` Daniel Lezcano
2018-04-26 11:51 ` [PATCH 13/18] thermal: exynos: set trips in ascending order in exynos7_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-05-01 10:02 ` Daniel Lezcano
2018-05-02 9:37 ` Bartlomiej Zolnierkiewicz [this message]
2018-04-26 11:51 ` [PATCH 14/18] thermal: exynos: move trips setting to exynos_tmu_initialize() Bartlomiej Zolnierkiewicz
2018-05-01 10:31 ` Daniel Lezcano
2018-05-02 9:39 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 15/18] thermal: exynos: check return values of ->get_trip_[temp,hyst] methods Bartlomiej Zolnierkiewicz
2018-05-01 10:43 ` Daniel Lezcano
2018-05-02 9:41 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 16/18] thermal: exynos: cleanup code for enabling threshold interrupts Bartlomiej Zolnierkiewicz
2018-05-01 11:02 ` Daniel Lezcano
2018-05-02 10:03 ` Bartlomiej Zolnierkiewicz
2018-05-02 11:04 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 17/18] thermal: exynos: remove unused defines for Exynos5433 Bartlomiej Zolnierkiewicz
2018-05-01 11:11 ` Daniel Lezcano
2018-05-02 10:05 ` Bartlomiej Zolnierkiewicz
2018-04-26 11:51 ` [PATCH 18/18] thermal: exynos: remove trip reporting to user-space Bartlomiej Zolnierkiewicz
2018-05-01 11:12 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3681690.4QzPMdFsyU@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox