Re: [PATCH] amd64_edac: fix insmod fail while ecc is enabled

[Doug Thompson <norsk5@yahoo.com>]

Thanks for this. 

It is the same as one I posted last week or so.

Without it, the module fails to initialize and no polling occurs.

Boris,  

In a prior email you indicated that you refactored the function in question. What that in the series of patches you submitted?  I think that set is too big to get in the RC branch.

We need this in 2.6.31 in order for the module to even work.

Shall we push my simple one, or your complete refactor?

doug t


--- On Mon, 7/27/09, wan wei <onewayforever@gmail.com> wrote:

> From: wan wei <onewayforever@gmail.com>
> Subject: [PATCH] amd64_edac: fix insmod fail while ecc is enabled
> To: dougthompson@xmission.com, borislav.petkov@amd.com
> Cc: linux-kernel@vger.kernel.org
> Date: Monday, July 27, 2009, 10:47 AM
> Signed-off-by: Wan Wei<wanwei@mail.dawning.com.cn>
> 
> diff --git a/drivers/edac/amd64_edac.c
> b/drivers/edac/amd64_edac.c
> index 858fe60..95b1096 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -2979,6 +2979,7 @@ static int
> amd64_check_ecc_enabled(struct amd64_pvt *pvt)
> 
>                 /*
> CLEAR the override, since BIOS controlled it */
>                
> ecc_enable_override = 0;
> +           
>    ret = 0;
>         }
> 
>         return ret;
>