From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Vince Weaver <vince@deater.net>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Gavin Hindman <gavin.hindman@intel.com>,
"Triplett, Josh" <josh.triplett@intel.com>
Subject: Re: [PATCH] powercap/rapl: add support for ValleyView Soc
Date: Sun, 22 Dec 2013 22:21:55 +0100 [thread overview]
Message-ID: <3683372.O2J0Fy185V@vostro.rjw.lan> (raw)
In-Reply-To: <alpine.DEB.2.02.1312221420400.13165@pianoman.cluster.toy>
On Sunday, December 22, 2013 02:22:48 PM Vince Weaver wrote:
> On Sun, 22 Dec 2013, Rafael J. Wysocki wrote:
> > On Wednesday, December 11, 2013 02:39:27 PM Jacob Pan wrote:
>
> > > @@ -941,6 +949,7 @@ static void package_power_limit_irq_restore(int package_id)
> > > static const struct x86_cpu_id rapl_ids[] = {
> > > { X86_VENDOR_INTEL, 6, 0x2a},/* SNB */
> > > { X86_VENDOR_INTEL, 6, 0x2d},/* SNB EP */
> > > + { X86_VENDOR_INTEL, 6, 0x37},/* VLV */
> > > { X86_VENDOR_INTEL, 6, 0x3a},/* IVB */
> > > { X86_VENDOR_INTEL, 6, 0x45},/* HSW */
> > > /* TODO: Add more CPU IDs after testing */
>
> This isn't a problem introduced in this patch, but it made me notice it...
>
> Would it really hurt anyone to spell out the architectures here, rather
> than using obscure 3-letter abbreviations? It's bad enough trying to
> map the hex model numbers to the decimal ones in /proc/cpuinfo without
> also having to remember what a VLV is.
I guess you can prepare a patch for that?
Rafael
prev parent reply other threads:[~2013-12-22 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 22:39 [PATCH] powercap/rapl: add support for ValleyView Soc Jacob Pan
2013-12-22 1:06 ` Rafael J. Wysocki
2013-12-22 19:22 ` Vince Weaver
2013-12-22 21:21 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3683372.O2J0Fy185V@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=gavin.hindman@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=josh.triplett@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox