From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ken Milmore <ken.milmore@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: nic_swsd@realtek.com,
"\"David S. Miller\",Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] r8169: Fix possible ring buffer corruption on fragmented Tx packets.
Date: Wed, 22 May 2024 07:35:06 +0200 [thread overview]
Message-ID: <36887d73-46a1-45d8-b55e-50e574f72aeb@gmail.com> (raw)
In-Reply-To: <27ead18b-c23d-4f49-a020-1fc482c5ac95@gmail.com>
On 22.05.2024 00:45, Ken Milmore wrote:
> An issue was found on the RTL8125b when transmitting small fragmented
> packets, whereby invalid entries were inserted into the transmit ring
> buffer, subsequently leading to calls to dma_unmap_single() with a null
> address.
>
> This was caused by rtl8169_start_xmit() not noticing changes to nr_frags
> which may occur when small packets are padded (to work around hardware
> quirks) in rtl8169_tso_csum_v2().
>
> To fix this, postpone inspecting nr_frags until after any padding has been
> applied.
>
> Fixes: 9020845fb5d6 ("r8169: improve rtl8169_start_xmit")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ken Milmore <ken.milmore@gmail.com>
> ---
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
next prev parent reply other threads:[~2024-05-22 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 22:45 [PATCH net v2] r8169: Fix possible ring buffer corruption on fragmented Tx packets Ken Milmore
2024-05-22 5:35 ` Heiner Kallweit [this message]
2024-05-23 13:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36887d73-46a1-45d8-b55e-50e574f72aeb@gmail.com \
--to=hkallweit1@gmail.com \
--cc=edumazet@google.com \
--cc=ken.milmore@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox