Re: [PATCH v27 12/12] LRNG - add power-on and runtime self-tests

Stephan Mueller
2020-01-10T07:49:33Z

Am Freitag, 10. Januar 2020, 01:22:51 CET schrieb Randy Dunlap:

Hi Randy,

> Hi,
>
> On 1/9/20 12:35 AM, Stephan Müller wrote:
> > ---
> >
> > drivers/char/lrng/Kconfig | 25 ++
> > drivers/char/lrng/Makefile | 1 +
> > drivers/char/lrng/lrng_selftest.c | 418 ++++++++++++++++++++++++++++++
> > 3 files changed, 444 insertions(+)
> > create mode 100644 drivers/char/lrng/lrng_selftest.c
> >
> > diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig
> > index 394066aa5a86..e9827e7df715 100644
> > --- a/drivers/char/lrng/Kconfig
> > +++ b/drivers/char/lrng/Kconfig
> > @@ -175,4 +175,29 @@ config LRNG_TESTING
> >
> > If unsure, say N.
> >
> > +config LRNG_SELFTEST
> > + bool "Enable power-on and on-demand self-tests"
> > + help
> > + The power-on self tests are executed during boot time
>
> self-tests

Fixed in all occurrences. Thank you.
>
> > + covering the ChaCha20 DRNG, the LFSR processing and the
> > + time stamp management of the LRNG.
> > +
> > + The on-demand self-tests are triggered by writing any
> > + value into the SysFS file selftest_status. At the same
> > + time, when reading this file, the test status is
> > + returned. A zero indicates that all tests were executed
> > + successfully.
> > +
> > + If unsure, say Y.
> > +
> > +if LRNG_SELFTEST
> > +
> > +config LRNG_SELFTEST_PANIC
> > + bool "Panic the kernel upon self-test failure"
> > + help
> > + If the option is enabled, the kernel is terminated if an
> > + LRNG power-on self-test failure is detected.
> > +
> > +endif # LRNG_SELFTEST
> > +
> >
> > endif # LRNG

Ciao
Stephan