From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: miquel.raynal@bootlin.com, tony@atomide.com, vigneshr@ti.com,
kishon@ti.com, nm@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] memory: omap-gpmc: Allow building as a module
Date: Fri, 29 Apr 2022 08:59:30 +0200 [thread overview]
Message-ID: <36ebec7d-e09a-241f-c7f2-457af7f19ae3@linaro.org> (raw)
In-Reply-To: <20220426082611.24427-3-rogerq@kernel.org>
On 26/04/2022 10:26, Roger Quadros wrote:
> Allow OMAP_GPMC to be built as a module.
>
> When building this driver as a module, the symbol
> 'of_default_bus_match_table' will not be found
> as it is not being exported.
>
> The of_match_node() call is redundant anyways as
> of_platform_default_populate() already takes care of
> matching with 'of_default_bus_match_table'. So get
> rid of that call. This will also resolve the
> module build failure.
>
> Move compatible match table to the end where it is
> usually expected.
Don't
use
some
unusual
wrapping
style.
Read
instead:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-29 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 8:26 [PATCH v4 0/2] memory: omap-gpmc: Allow module build Roger Quadros
2022-04-26 8:26 ` [PATCH v4 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros
2022-04-26 8:26 ` [PATCH v4 2/2] memory: omap-gpmc: Allow building as a module Roger Quadros
2022-04-29 6:59 ` Krzysztof Kozlowski [this message]
2022-04-26 8:40 ` [PATCH v4 0/2] memory: omap-gpmc: Allow module build Roger Quadros
2022-04-29 6:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ebec7d-e09a-241f-c7f2-457af7f19ae3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox