From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FF4426ED40 for ; Wed, 13 May 2026 16:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778688750; cv=none; b=jv7ZyFFwey609Gs0DJLQqoPlyl1Ae4zQKsOJbhWJ3DCQjsTxo+c/pjZRUhsFkusBYerL9qkG5UZoM2dCYEHCevKBwvupsdS+jmQPXc7xIRuDFaLXuWWWkZ9ahVO/iFqiaMXefLPDMukPV40MKgT9VCn9XKu/ww6r7z9zwa1L8bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778688750; c=relaxed/simple; bh=Lf94+U8uB4d6shrtPK64fSV3D5WpuG9aew0bJ7m7ysA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YyzvKTlw8cQQl3PzCznCHoNeWiOpp7usDlIH4LO6n526hhEEBOm4ONHk3q1q0Z++5BJAi0m8+2NTSIV5QOfrfPKjbwkMzJNQL6FkfiJgaXnimgb7qnNB9v4Q50nbo52DCbP3AcQyZvSXipUXcSX0XfRNot90jWpBOM1IsK0cCUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j8FWFoJe; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j8FWFoJe" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43fe3e22e33so4242836f8f.0 for ; Wed, 13 May 2026 09:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778688747; x=1779293547; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ai6dR/bymyCWlBYI6Ti2e17lWUNYyrdNZIbrxhMJBME=; b=j8FWFoJeQy3kVUFweQOdgG+jhq3GxPuxV5CSbOUCvNaJkCB72i3ljiUCHNk7e3todL sQ2/vQ0BbSCox0NoNCVLuaUZ9eAb6aRkmV07WIfftcmrVyeUbzUwUtN+Sawm63bN0Ifo wfsWfTurOZrU22m7tyLx8JQmrQGRtVw0AmzSNkYzWDxbbLBaxJ7LeXnMkHUB5Ib1Gkil /dxrDopoJiD/amFH+hTvAqmKHcBel5m3A+rfRKxUfT9S6vzBo4JTodDJXCkxKudlsAon 2iz3inK7NJ4Ut8bB4bD7wa1nnuHCsW+Tg7t9eyU42n2eGONDD8EnVrQA6X2KLcK2c6uj oyVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778688747; x=1779293547; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ai6dR/bymyCWlBYI6Ti2e17lWUNYyrdNZIbrxhMJBME=; b=K710MEXsyls+FQoQoqPLiOYxA31CmwavwS+mdC7oXwI0gY0GIhK6kix5xsVRiuxVR7 G9xsmisddENL2hk59tjvlOfUQIx3CQF9b8PFOCi1oR4buyN2LA3dfAb5JyDXGka0PEbI ZJ8LSh1ftpAl/g5OkwbO8CsZWw1RCkJXKeUI+Scs85Kg2GL/KUo+xH8hx5bL7maBx1GP acqkAyAHybFEX1gudunxRUujlzpx14CpwhdpQWBC+DRCprt4js/1Ph3Ci/PXlr//maRs Av722bVOiZ7qXo/wPb/AdS43NGsEP6LAXSuURNaaBpRxyth0zE8RruEsYWzezH5iABLq xL8Q== X-Forwarded-Encrypted: i=1; AFNElJ+/Nv0WptWDn+aov7nepN/rLXjWhcG4qBxCQjFv+AkV8swiznuN+fApJwXIopUqikV87wr62hPWtO3yQZA=@vger.kernel.org X-Gm-Message-State: AOJu0YxJAS/eUuNQWxZI5GVZ5nnWMHFUP9ps4Ve3YwTH8KrdHxac4BEA PRYbg7HIwHHuc7E3JKP9tCbmsCYXwCbiRwLz+CnpsieSOSc1KumW/DBw X-Gm-Gg: Acq92OGYaZASCPGteQ4i4IOg67/CzTc6RIIUaFVFtzIJSBUizwDvkkRD8YkMueV/jed c7ZNJlweiNQ9e/LzoUAqZp1isk2PcfvyLDgkwYs3adQvGcpnnrHiLBdbr+2c1/LUuXgGstG3vN0 VZJSLJCsq/it3bj1PUvm/8ZgHgEn7r64RqzNa9rQf5ZMqUEvny2UTtSwolaE+3mAMlMAKdvHbXj PalW9GjvMETGcLaM0p/9/eMw47LHg9k6PHw7z9AmREErNrGysmPtQn2KDNKf9kjssykvK31fk4J aPbCrq1Aqvek+JpvNftGzcM87YRwoxPQSL3uFYimzGgy+n4UOmrq4R4xGB+aQqD+KqUXddMwDs8 O+GOvOhLfZbccJH1sT6QZHUbnCSz3gfZN1iszy0yxYRt39J9P9S4XSQ+Rgvhz3UTARukVf5PsmQ mYmXID9mEqGoC7wlzfD3t/D8tP17tQPA== X-Received: by 2002:a05:6000:220c:b0:44f:f4de:a844 with SMTP id ffacd0b85a97d-45c5a392f2fmr6242310f8f.37.1778688746247; Wed, 13 May 2026 09:12:26 -0700 (PDT) Received: from [192.168.37.44] ([217.61.173.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491bae13csm40293279f8f.29.2026.05.13.09.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 09:12:25 -0700 (PDT) Message-ID: <36ed59a7-8af7-4458-9e90-70ea251b389e@gmail.com> Date: Wed, 13 May 2026 18:12:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] iio: light: tcs3472: move standalone return to default case To: Andy Shevchenko Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, shuah@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev References: <20260512223215.25596-1-aldocontelk@gmail.com> <20260512223215.25596-6-aldocontelk@gmail.com> Content-Language: en-US From: Aldo Conte In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/13/26 13:23, Andy Shevchenko wrote: > On Wed, May 13, 2026 at 12:32:15AM +0200, Aldo Conte wrote: >> Move the trailing 'return -EINVAL' statements at the end of >> tcs3472_read_raw() and tcs3472_write_raw() into explicit default: >> cases inside the respective switch statements. >> >> This removes the need for a separate return statement after the switch. >> >> No functional change. > > Reviewed-by: Andy Shevchenko > Hi Andy, Joshua, Thanks for the review. Before I send v3, I want to make sure I split the series the way you want. My plan is to split v2 into 7 patches: 1. sort headers (same as v2) 2. convert locking to guard(mutex) (drop Suggested-by, clean up trigger_handler) 3. replace == NULL with ! (add Suggested-by: Joshua Crofts) 4. use devm for resource management (drop Suggested-by, remove the dev_info change, add devm_mutex_init) 5. use 'dev' for dev_info() calls (new, taken out of patch 4) 6. implement wait time and sampling_frequency (drop Suggested-by, fix macro style, simplify cycle_us and all the other revisions) 7. move standalone return to default case (same as v2) Two things I am not sure about: - Should patch 3 ("replace == NULL with !") really be its own patch, or do you prefer it inside patch 4, since that line is right next to devm_iio_device_alloc? - Is patch 5 (dev_info refactor) in the right place after the devm patch? Aldo