From: "Евгений Поляков" <zbr@ioremap.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] w1: small cleanup in w1_family_notify()
Date: Sun, 01 Mar 2015 04:49:14 +0300 [thread overview]
Message-ID: <370051425174554@web4m.yandex.ru> (raw)
In-Reply-To: <20150220105302.GB7895@mwanda>
Hi Dan
20.02.2015, 13:53, "Dan Carpenter" <dan.carpenter@oracle.com>:
> "sl->family->fops" and "fops" are the same thing, but it's nicer to use
> "fops" everywhere.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good to me, thank you
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index 181f41c..59f932f 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -649,7 +649,7 @@ static int w1_family_notify(unsigned long action, struct w1_slave *sl)
> break;
> case BUS_NOTIFY_DEL_DEVICE:
> if (fops->remove_slave)
> - sl->family->fops->remove_slave(sl);
> + fops->remove_slave(sl);
> if (fops->groups)
> sysfs_remove_groups(&sl->dev.kobj, fops->groups);
> break;
prev parent reply other threads:[~2015-03-01 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 10:53 [patch] w1: small cleanup in w1_family_notify() Dan Carpenter
2015-03-01 1:49 ` Евгений Поляков [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370051425174554@web4m.yandex.ru \
--to=zbr@ioremap.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox