From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbbCAByY (ORCPT ); Sat, 28 Feb 2015 20:54:24 -0500 Received: from forward2m.mail.yandex.net ([37.140.138.2]:55283 "EHLO forward2m.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbbCAByV (ORCPT ); Sat, 28 Feb 2015 20:54:21 -0500 X-Greylist: delayed 303 seconds by postgrey-1.27 at vger.kernel.org; Sat, 28 Feb 2015 20:54:21 EST From: =?koi8-r?B?5dfHxc7JyiDwz8zRy8/X?= Envelope-From: drustafa@yandex.ru To: Dan Carpenter Cc: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" In-Reply-To: <20150220105302.GB7895@mwanda> References: <20150220105302.GB7895@mwanda> Subject: Re: [patch] w1: small cleanup in w1_family_notify() MIME-Version: 1.0 Message-Id: <370051425174554@web4m.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sun, 01 Mar 2015 04:49:14 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan 20.02.2015, 13:53, "Dan Carpenter" : > "sl->family->fops" and "fops" are the same thing, but it's nicer to use > "fops" everywhere. > > Signed-off-by: Dan Carpenter Looks good to me, thank you Acked-by: Evgeniy Polyakov > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 181f41c..59f932f 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -649,7 +649,7 @@ static int w1_family_notify(unsigned long action, struct w1_slave *sl) > šššššššššššššššššbreak; > šššššššššcase BUS_NOTIFY_DEL_DEVICE: > šššššššššššššššššif (fops->remove_slave) > - sl->family->fops->remove_slave(sl); > + fops->remove_slave(sl); > šššššššššššššššššif (fops->groups) > šššššššššššššššššššššššššsysfs_remove_groups(&sl->dev.kobj, fops->groups); > šššššššššššššššššbreak;