From: Keith Owens <kaos@ocs.com.au>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch(?): pci_device_id tables for linux-2.4.0-test11/drivers/block
Date: Thu, 23 Nov 2000 09:36:08 +1100 [thread overview]
Message-ID: <3702.974932568@ocs3.ocs-net> (raw)
In-Reply-To: Your message of "Wed, 22 Nov 2000 14:01:36 -0800." <200011222201.OAA29131@baldur.yggdrasil.com>
On Wed, 22 Nov 2000 14:01:36 -0800,
"Adam J. Richter" <adam@yggdrasil.com> wrote:
> Just to avoid duplication of effort, I am posting this preliminary
>patch which adds PCI MODULE_DEVICE_TABLE declarations to the three PCI
>drivers in linux-2.4.0-test11/drivers/block. In response to input from
>Christoph Hellwig, I have reduced my threshhold on using named initializers
>to three entries, although I think that may be going to far, as I would
>really like to keep the number of files that initialize the pci_device_id
>arrays this way low so that changing struct pci_device_id remains feasible.
No need for named initializers. Always add any new fields in struct
pci_device_id at the end. It does matter if you use named or unnamed
initializers, the new fields will be zero on all existing declarations.
Introducing new fields in the middle of pci_device_id introduces
version skew problems for modutils and all code that reads
modules.pcimap.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-22 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-22 22:01 Patch(?): pci_device_id tables for linux-2.4.0-test11/drivers/block Adam J. Richter
2000-11-22 22:14 ` Jeff Garzik
2000-11-22 22:18 ` Andi Kleen
2000-11-22 22:34 ` Jeff Garzik
2000-11-22 22:36 ` Keith Owens [this message]
2000-11-23 0:50 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2000-11-23 2:18 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3702.974932568@ocs3.ocs-net \
--to=kaos@ocs.com.au \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox