From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161070AbcFBVAH (ORCPT ); Thu, 2 Jun 2016 17:00:07 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:38825 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932171AbcFBVAF (ORCPT ); Thu, 2 Jun 2016 17:00:05 -0400 From: Laurent Pinchart To: Boris Brezillon Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Alexey Brodkin , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Stefan Agner , Alison Wang , Matthias Brugger , Rob Clark , Mark Yao , Heiko Stuebner , Benjamin Gaignard , Vincent Abriou , Maxime Ripard , Chen-Yu Tsai , Thierry Re ding , Stephen Warren , Alexandre Courbot , Eric Anholt , Gerd Hoffmann , linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 16/20] drm: omap: Rely on the default ->best_encoder() behavior Date: Fri, 03 Jun 2016 00:00:07 +0300 Message-ID: <3702911.4V6efqXNem@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.16; x86_64; ; ) In-Reply-To: <1464877907-27723-17-git-send-email-boris.brezillon@free-electrons.com> References: <1464877907-27723-1-git-send-email-boris.brezillon@free-electrons.com> <1464877907-27723-17-git-send-email-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, Thank you for the patch. On Thursday 02 Jun 2016 16:31:43 Boris Brezillon wrote: > We have a 1:1 relationship between connectors and encoders and the > driver is relying on the atomic helpers: we can drop the custom > ->best_encoder() implementation and let the core call > drm_atomic_helper_best_encoder() for us. > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/omapdrm/omap_connector.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c > b/drivers/gpu/drm/omapdrm/omap_connector.c index ce2d67b..80af5e1 100644 > --- a/drivers/gpu/drm/omapdrm/omap_connector.c > +++ b/drivers/gpu/drm/omapdrm/omap_connector.c > @@ -256,13 +256,6 @@ static int omap_connector_mode_valid(struct > drm_connector *connector, return ret; > } > > -struct drm_encoder *omap_connector_attached_encoder( > - struct drm_connector *connector) > -{ > - struct omap_connector *omap_connector = to_omap_connector(connector); > - return omap_connector->encoder; The omap_connector::encoder field is assigned but not used anymore, you can remove it. With that fixed, Reviewed-by: Laurent Pinchart > -} > - > static const struct drm_connector_funcs omap_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .reset = drm_atomic_helper_connector_reset, > @@ -276,7 +269,6 @@ static const struct drm_connector_funcs > omap_connector_funcs = { static const struct drm_connector_helper_funcs > omap_connector_helper_funcs = { .get_modes = omap_connector_get_modes, > .mode_valid = omap_connector_mode_valid, > - .best_encoder = omap_connector_attached_encoder, > }; > > /* initialize connector */ -- Regards, Laurent Pinchart