Re: [PATCH v5 4/7] drm/panel: simple: Use display_timing for Innolux n116bge

Thierry Reding
2019-06-28T23:50:34Z

[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]

On Mon, Apr 01, 2019 at 10:17:21AM -0700, Douglas Anderson wrote:
> Convert the Innolux n116bge from using a fixed mode to specifying a
> display timing with min/typ/max values.
>
> Note that the n116bge's datasheet doesn't fit too well into DRM's way
> of specifying things. Specifically the panel's datasheet just
> specifies the vertical blanking period and horizontal blanking period
> and doesn't break things out. For now we'll leave everything as a
> fixed value but just allow adjusting the pixel clock. I've added a
> comment on what the datasheet claims so someone could later expand
> things to fit their needs if they wanted to test other blanking
> periods.
>
> The goal here is to be able to specify the panel timings in the device
> tree for several rk3288 Chromebooks (like rk3288-veryon-jerry). These
> Chromebooks have all been running in the downstream kernel with the
> standard porches and sync lengths but just with a slightly slower
> pixel clock because the 76.42 MHz clock is not achievable from the
> fixed PLL that was available. These Chromebooks only achieve a
> refresh rate of ~58 Hz. While it's probable that we could adjust the
> timings to achieve 60 Hz it's probably wisest to match what's been
> running on these devices all these years.
>
> I'll note that though the upstream kernel has always tried to achieve
> 76.42 MHz, it has actually been running at 74.25 MHz also since the
> video processor is parented off the same fixed PLL.
>
> Changes in v4:
> - display_timing for Innolux n116bge new for v4.
>
> Changes in v5:
> - Added Heiko's Tested-by
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 37 +++++++++++++++++-----------
> 1 file changed, 23 insertions(+), 14 deletions(-)

Acked-by: Thierry Reding <thierry.reding@gmail.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]