Re: [PATCH v5 2/7] drm/panel: simple: Add ability to override typical timing

Sam Ravnborg
2019-06-30T20:55:26Z

Hi Douglas.

> > +
> > + /* Only add timings if override was not there or failed to validate */
> > + if (num == 0 && panel->desc->num_timings)
> > + num = panel_simple_get_timings_modes(panel);
> > +
> > + /*
> > + * Only add fixed modes if timings/override added no mode.
>
> This part I fail to understand.
> If we have a panel where we in panel-simple have specified the timings,
> and done so using display_timing so with proper {min, typ, max} then it
> should be perfectly legal to specify a more precise variant in the DT
> file.
> Or what did I miss here?

Got it now.
If display_mode is used for timings this is what you call "fixed mode".
Hmm, if I got confused someone else may also be confused by this naming.

Sam