From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E6747CC7E for ; Mon, 11 May 2026 18:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778524263; cv=none; b=Lujr29SDoUa1Wzk41menNSNW1og8RRsk1pezWdKkokzAWk1amxDQGtFAdtGvqa68Qvbrh+bmhbkZbfGCfOzgjZLRZ0fzlot3iGOFTjbC8w0D9hsFBehoM4lRlwLksw51R6/ZvxUhtc3jHyyQKQSS3t5c5eo+neltAX5xxPvGtoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778524263; c=relaxed/simple; bh=EGNBeWGj//FtEgqBI6u1TnkDCr3A5GP106MZey7UBZg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=II9umeHcqgtojxJELYV7Ey+hJKOC8kIW3PbQZr9usQhsJsVNbuW7ummYsqALtIdjyqmU6yd4FXhWL3OEkDaddNzpwBbHzmMcKubJNbnt07VSRAKtWaDEuemdTRCZXRiyRYq+M0LglRct3VfloV9oqCk1AWdMtpyOtfl2ADKQknw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p/8ZIydK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p/8ZIydK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CD5BC2BCB0; Mon, 11 May 2026 18:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778524263; bh=EGNBeWGj//FtEgqBI6u1TnkDCr3A5GP106MZey7UBZg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=p/8ZIydKvITZ9Zj2K67WABbe66oyuylMByZNJuJY+mfZnekChL26b8YcO90CRtTMh gYjJxv5JgCucqMMxDsR8XEoYhIbuiXOeeQMZJVIhZkyK/+2qT4xhnQCVmcru40FcRH GluUwo18XFwH+hm2NTzMF1mfs4iXIxkGvaMx1IaYsvyv0OrLHduc+0gO90Ay9sA6wK B0dHNpDIIbIYAQLzKl3hDu8n+Zw1IpVTdNZ7WMMGKSuhEyRakAucAfX11JMJjK9E1Y VoRPiUtDO5jxdGK0FTMwvYuswTA4trFwltBbx4zTSb08shtKXCvdlslki/beRemppR 4h2irLt+OI6Lw== Message-ID: <3706e714-f60e-4178-afe1-c1973e43bdb3@kernel.org> Date: Mon, 11 May 2026 20:30:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 15/22] mm/page_alloc: remove ifdefs from pindex helpers Content-Language: en-US To: Brendan Jackman , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, rppt@kernel.org, Sumit Garg , derkling@google.com, reijiw@google.com, Will Deacon , rientjes@google.com, patrick.roy@linux.dev, "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-15-28bf1bd54f41@google.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20260320-page_alloc-unmapped-v2-15-28bf1bd54f41@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/20/26 19:23, Brendan Jackman wrote: > The ifdefs are not technically needed here, everything used here is > always defined. > > They aren't doing much harm right now but a following patch will > complicate these functions. Switching to IS_ENABLED() makes the code a > bit less tiresome to read. > > Signed-off-by: Brendan Jackman Reviewed-by: Vlastimil Babka (SUSE) Also good for prep series?