From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbbJWNJo (ORCPT ); Fri, 23 Oct 2015 09:09:44 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58102 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbbJWNJm (ORCPT ); Fri, 23 Oct 2015 09:09:42 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Eric Auger , eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@linaro.org, patches@linaro.org Subject: Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro Date: Fri, 23 Oct 2015 15:09:04 +0200 Message-ID: <3721718.lcvGuESNdi@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445603835-14506-4-git-send-email-eric.auger@linaro.org> References: <1445603835-14506-1-git-send-email-eric.auger@linaro.org> <1445603835-14506-4-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ljnAGQFsZyBWAb0sW09ua4TH/g3YmR37LJvyfxBuimQsTbGD3XW 5KQp9KL0sIbTw/aM2tbdjbMBHnriMoBo2DvhYquWCV+7zF1jTq0Hq9XQmZ+4TcPBVWD3GbD HUfcrErl453ODXO59t4VX+KCWBUX0SS/NV3o75pyrtWFZWWQBRZqqMMHjwPPmmoP0UJf33U V/SeH3+NwuYz6LuSCpbvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0PP68NuUTFg=:cJjHQaq5PlCTahgxnDIJ4K VxC/JgKvkGeIyODtkzu0y6zj/FDq5GULGriedS1dzxhuC8J+BXL0eA7lKAdGEsW0NGbkBmbja 6+lmOKoCKWPDNhYBtG/W0SFCZyO+gOd50uqdvdpcZNqFLWh+Iv9ThVj7trUyc8ENb8RLFiOWK MBUWO2mAoaDoDAbVgFYEdHptvBP845Sxg4IwZvVEbybbEboEa1Javz1caolTDU41obV74OWDc 1REXp+jg2l81lTZBM4GXhABJh3SDL+KCAsS8xXGYGe/UMM8t8wDdpJmZdLt3nNNdzDyF9A3lE lUQX+I6NkyGgEa/Ya7SyoZNvBSL/wsRjJC0bKgJK9R7yW3eaVImoXYEh+oDnZuHsWM8kf6mDC v8BIRFbXwwu+YvHD0GfYKfNwloWHFZ7WHKshCXjKiB9lgGgWXW/c/StYl0c3HU0jerVTLlRO/ oia/sv4hDdOYpXLVZnvrI9QX+a1EGUPYoJm25e++nhkcRXkikscNE1swok2S7r4PDdrOrDkjd /NRN35IBE0Q5ZUsOk5VfMO+eRbXDScJPW16f7k0IrDStGrgb83WhIXzjIlNPH0C/6hWzyz0Ji iQqgQxzdQuTdmVv1p1r3n2FZlDoLmjguVrErOXkyuJArTkOGywqzPu8xc0gsvftjMFhn+F5Dv R5hrcOQQG3rgdkTpGMpE14MKT5kDPBMaZRbcmTZy9gFxym9GQ/jh0jNnhJ16bfSyip79uLjlM J8amGyuz7Nk8S6Jj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 October 2015 14:37:11 Eric Auger wrote: > +static int __init reset ## _module_init(void) \ > +{ \ > + vfio_platform_register_reset(compat, reset); \ > + return 0; \ > +}; \ > I would make this 'return vfio_platform_register_reset(...)', so loading the driver fails if the handler cannot get registered. Alternatively, change the return type of vfio_platform_register_reset to 'void' so it can never fail. Arnd