From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933086AbdBQImB (ORCPT ); Fri, 17 Feb 2017 03:42:01 -0500 Received: from mx5-phx2.redhat.com ([209.132.183.37]:52901 "EHLO mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933015AbdBQIl6 (ORCPT ); Fri, 17 Feb 2017 03:41:58 -0500 Date: Fri, 17 Feb 2017 03:41:58 -0500 (EST) From: Paolo Bonzini To: Bandan Das Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Message-ID: <372283237.23068299.1487320918001.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1487169866-14989-1-git-send-email-pbonzini@redhat.com> Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.164.1, 10.5.100.50] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF51 (Linux)/8.0.6_GA_5922) Thread-Topic: use vmcs_set/clear_bits for CPU-based execution controls Thread-Index: xdxDMH1G6byYcuRKenGXvmrKIE5mCQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: "Bandan Das" > To: "Paolo Bonzini" > Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org > Sent: Friday, February 17, 2017 1:04:14 AM > Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls > > Paolo Bonzini writes: > > > Signed-off-by: Paolo Bonzini > > --- > > I took a quick look and found these two potential > consumers of these set/clear wrappers. > > vmcs_set_secondary_exec_control() > vmx_set_virtual_x2apic_mode() > > Since this has been reviewed already, > we can just have them later in a follow up > (unless you left them out intentionally). Both of these can both set and clear bits, so they could be the consumer of a new function void vmcs_write_bits(u16 field, u32 value, u32 mask) but I don't see much benefit in introducing it; the cognitive load is higher than vmcs_{set,clear}_bits. Paolo