From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752254AbbKGJCk (ORCPT ); Sat, 7 Nov 2015 04:02:40 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:49620 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903AbbKGJCh (ORCPT ); Sat, 7 Nov 2015 04:02:37 -0500 From: Arnd Bergmann To: Guenter Roeck Cc: Rob Herring , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: Provide static inline function for of_translate_address if needed Date: Sat, 07 Nov 2015 10:02:20 +0100 Message-ID: <3724502.6sHTjrfvab@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1446866902-31492-1-git-send-email-linux@roeck-us.net> References: <1446866902-31492-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:y6DCbGw0B6kthgkU8AhHz/9xTw4+ihCRdcByfkR9hv64MqJRdem vASZMWgXazIaHvDc+Sp/RBB7qfNbtK4E7rR2LcIj/vjiJ7B93w5XrIZZdWVbaQvaKDb8k8t vIDzJXejM4pJGo36hKHPofz1dXzNCVJ0zXGbzxchu/mFQJ1pc67BfuIXKIEeKuclYIvmUdk LmMIqd02hdq7GvMPtjFvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:9a7C3gYoJ48=:Gl8jtHroQaZruURlpSjNzn rPebcoiefpPSjHhgKroasFLt7fvUHEmUa3c8gpQHvPKeQ4vEESNrkMtlB057cffZg77MyYyAU NO/XKHas6B7DBIHNWW0SxPPfv1GPnGiLNB9jXL4V+ZyfvNEz3YHB7X1a7CjIgZbx6p9zigVe0 UUozkjP23JkANP5Mv4PN2X9gzt7pJ9mT8H2VChTuKgx0A5sMBysN/us1CzwG/JqJU1ihC8n1I x3/sjrN5zFYl624x+2oWgVnP5lDRFs3BBHuDkYBUqo5mz8iJ3nAIAJgwnT8ztimBSCbGSIzh9 Z5qOC3f4tH14e7A31A/lbxfZ1bKLQkMqHycRIia/2TxAGyj7PJwtH4bTACIz0eGuuA0/f/XC9 PHn3A/ZFYgttPjgQq7xZPI5qJMyXqqNdfwEYjLWiozEmd4UFjOGQz9KoS99u6VwsQdvsJJMVm 0GahGhDJ7eYcknEe5cLdKF11EBZPKFazPQtiSL9WZKJj1BBLq69ImSgLy55G0eeclk5pMguw2 7fKQ1DT+rkhZjKkC/zIbTzrkmaUUvnN/58eMakJX/Z4GC2YW316aAQUnQkd4F018VWnosUrth X079xvVpt7pHnn/DKkapaazab7HHHd1PKmKphjY+IT+Rr55+YSCDpT7BblqCZnr4YG+w7/Ebc 1jcitAdXk5FkEDs0rAxu5BHENoo25h0elVctt86+0JwyYWlt7ouktUQcDc71iATmOeMfC22Li 2flc6Wj0la8oP0Cx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 06 November 2015 19:28:22 Guenter Roeck wrote: > If OF_ADDRESS is not configured, builds can fail with errors such as > > drivers/net/ethernet/hisilicon/hns_mdio.c: > In function 'hns_mdio_bus_name': > drivers/net/ethernet/hisilicon/hns_mdio.c:411:3: > error: implicit declaration of function 'of_translate_address' > > as currently seen when building sparc:allmodconfig. > > Introduce a static inline function if OF_ADDRESS is not configured to fix > the build failure. Return OF_BAD_ADDR in this case. For this to work, the > definition of OF_BAD_ADDR has to be moved outside CONFIG_OF conditional > code. > > Fixes: 876133d3161d ("net: hisilicon: add OF dependency") > Cc: Arnd Bergmann > Signed-off-by: Guenter Roeck Reviewed-by: Arnd Bergmann Thanks for the fix. Rob/Frank, any chance we get this into -rc1 through your tree? The background is that a bugfix I did for a network driver started causing the build error on sparc allmodconfig, and it would be nice to have 4.4-rc1 build fine without having to back out my fix. Arnd