From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbcKBX4r (ORCPT ); Wed, 2 Nov 2016 19:56:47 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:34907 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbcKBX4q (ORCPT ); Wed, 2 Nov 2016 19:56:46 -0400 Subject: Re: [PATCHv2 5/6] arm64: Use __pa_symbol for _end To: Mark Rutland References: <20161102210054.16621-1-labbott@redhat.com> <20161102210054.16621-6-labbott@redhat.com> <20161102225241.GA19591@remoulade> Cc: Ard Biesheuvel , Will Deacon , Catalin Marinas , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Marek Szyprowski , Joonsoo Kim , linux-arm-kernel@lists.infradead.org From: Laura Abbott Message-ID: <3724ea58-3c04-1248-8359-e2927da03aaf@redhat.com> Date: Wed, 2 Nov 2016 17:56:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161102225241.GA19591@remoulade> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2016 04:52 PM, Mark Rutland wrote: > On Wed, Nov 02, 2016 at 03:00:53PM -0600, Laura Abbott wrote: >> >> __pa_symbol is technically the marco that should be used for kernel >> symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL. > > Nit: s/marco/macro/ > > I see there are some other uses of __pa() that look like they could/should be > __pa_symbol(), e.g. in mark_rodata_ro(). > > I guess strictly speaking those need to be updated to? Or is there a reason > that we should not? > If the concept of __pa_symbol is okay then yes I think all uses of __pa should eventually be converted for consistency and debugging. > Thanks, > Mark. > >> Signed-off-by: Laura Abbott >> --- >> arch/arm64/mm/init.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >> index 212c4d1..3236eb0 100644 >> --- a/arch/arm64/mm/init.c >> +++ b/arch/arm64/mm/init.c >> @@ -209,8 +209,8 @@ void __init arm64_memblock_init(void) >> * linear mapping. Take care not to clip the kernel which may be >> * high in memory. >> */ >> - memblock_remove(max_t(u64, memstart_addr + linear_region_size, __pa(_end)), >> - ULLONG_MAX); >> + memblock_remove(max_t(u64, memstart_addr + linear_region_size, >> + __pa_symbol(_end)), ULLONG_MAX); >> if (memstart_addr + linear_region_size < memblock_end_of_DRAM()) { >> /* ensure that memstart_addr remains sufficiently aligned */ >> memstart_addr = round_up(memblock_end_of_DRAM() - linear_region_size, >> -- >> 2.10.1 >>