From: David Howells <dhowells@redhat.com>
To: Peng Zhang <zhangpeng362@huawei.com>
Cc: dhowells@redhat.com, ericvh@gmail.com, lucho@ionkov.net,
asmadeus@codewreck.org, linux_oss@crudebyte.com,
jlayton@kernel.org, v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
syzbot+a76f6a6e524cf2080aa3@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] fscache: fix OOB Read in __fscache_acquire_volume
Date: Thu, 17 Nov 2022 15:14:34 +0000 [thread overview]
Message-ID: <3725574.1668698074@warthog.procyon.org.uk> (raw)
In-Reply-To: <20221115140447.2971680-1-zhangpeng362@huawei.com>
I think that the size needs to be able to hold up to 255 to handle NFS keys,
so I think the right solution has to be to fix the maths. Probably the
easiest way is to change fscache_volume::key to be "u8 *" since it
isn't a simple text string.
David
prev parent reply other threads:[~2022-11-17 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 14:04 [PATCH v2] fscache: fix OOB Read in __fscache_acquire_volume Peng Zhang
2022-11-15 22:16 ` asmadeus
2022-11-17 15:14 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3725574.1668698074@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=syzbot+a76f6a6e524cf2080aa3@syzkaller.appspotmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox