From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: ISHIKAWA Mutsumi <ishikawa@linux.or.jp>, jejb@steeleye.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix
Date: Tue, 11 Feb 2003 13:06:41 -0700 [thread overview]
Message-ID: <3729142704.1044994000@aslan.btc.adaptec.com> (raw)
In-Reply-To: <20030211182558.DED278DC14@master.hanzubon.jp>
> This patch will fix two problems.
>
> fix build problem related scsi_cmnd changes
The aic7xxx driver has one place that missed the conversion too.
Since the cmd->lun field is no longer filled in, why hasn't the
field been removed from the cmd structure? That would make it
easy to catch these kinds of bugs.
Thanks for the report. We're close to doing another aic79xx
driver drop and I'll incorporate the change then.
--
Justin
>
> http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/scsi/aic7xxx/aic79xx_osm.c@1.16?nav=index.html|src/|src/drivers|src/drivers/scsi|src/drivers/scsi/aic7xxx|hist/drivers/scsi/aic7xxx/aic79xx_osm.c
>
> This change(latest aic79xx driver and scsi_cmnd changes merging)
> is dropped `hscb->lun = cmd->device->lun;' (in aic79xx_osm.c line
> 4272). This change cause lun detect problem. I believe it is still
> needed.
>
>
> --- linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c.orig 2003-02-11 14:58:01.000000000 +0900
> +++ linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c 2003-02-11 16:08:00.000000000 +0900
> @@ -1560,7 +1560,7 @@
> hscb = scb->hscb;
> hscb->control = 0;
> hscb->scsiid = BUILD_SCSIID(ahd, cmd);
> - hscb->lun = cmd->lun;
> + hscb->lun = cmd->device->lun;
> hscb->cdb_len = 0;
> hscb->task_management = SIU_TASKMGMT_LUN_RESET;
> scb->flags |= SCB_DEVICE_RESET|SCB_RECOVERY_SCB|SCB_ACTIVE;
> @@ -4269,6 +4269,7 @@
> */
> hscb->control = 0;
> hscb->scsiid = BUILD_SCSIID(ahd, cmd);
> + hscb->lun = cmd->device->lun;
> scb->hscb->task_management = 0;
> mask = SCB_GET_TARGET_MASK(ahd, scb);
>
>
> --
> ISHIKAWA Mutsumi
> <ishikawa@linux.or.jp>, <ishikawa@debian.org>, <ishikawa@netvillage.co.jp>
next prev parent reply other threads:[~2003-02-11 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-11 18:25 [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix ISHIKAWA Mutsumi
2003-02-11 20:06 ` Justin T. Gibbs [this message]
2003-02-11 20:21 ` Christoph Hellwig
2003-02-11 20:36 ` Christoph Hellwig
2003-02-11 20:52 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3729142704.1044994000@aslan.btc.adaptec.com \
--to=gibbs@scsiguy.com \
--cc=ishikawa@linux.or.jp \
--cc=jejb@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox