From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 07/14] readahead: call scheme: catch thrashing on lookahead time
Date: Fri, 16 Mar 2007 16:49:03 +0800 [thread overview]
Message-ID: <374035059.35424@ustc.edu.cn> (raw)
Message-ID: <20070316085052.550263000@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070316084856.687942000@mail.ustc.edu.cn
[-- Attachment #1: readahead-call-scheme-catch-thrashing-on-lookahead-time.patch --]
[-- Type: text/plain, Size: 1368 bytes --]
Move the call to thrashing_recovery_readahead() before state_based_readahead().
That catches the rare case where thrashing happened on the time we are to read
the page at ra->lookahead_index. Obviously this case should be handled by
thrashing_recovery_readahead() instead of state_based_readahead().
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
mm/readahead.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
--- linux-2.6.21-rc3-mm2.orig/mm/readahead.c
+++ linux-2.6.21-rc3-mm2/mm/readahead.c
@@ -1638,6 +1638,13 @@ page_cache_readahead_adaptive(struct add
return initial_readahead(mapping, filp, ra, req_size);
/*
+ * Recover from possible thrashing.
+ */
+ if (!page && offset - ra->prev_page <= 1 && ra_has_index(ra, offset))
+ return thrashing_recovery_readahead(mapping, filp, ra,
+ offset, ra_max);
+
+ /*
* State based sequential read-ahead.
*/
if (offset == ra->prev_page + 1 &&
@@ -1647,13 +1654,6 @@ page_cache_readahead_adaptive(struct add
offset, req_size, ra_max);
/*
- * Recover from possible thrashing.
- */
- if (!page && offset - ra->prev_page <= 1 && ra_has_index(ra, offset))
- return thrashing_recovery_readahead(mapping, filp, ra,
- offset, ra_max);
-
- /*
* Backward read-ahead.
*/
if (!page && try_backward_prefetching(ra, offset, req_size, ra_max))
--
next prev parent reply other threads:[~2007-03-16 8:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070316084856.687942000@mail.ustc.edu.cn>
2007-03-16 8:48 ` [PATCH 00/14] Adaptive readahead update Fengguang Wu
[not found] ` <20070316085051.601015000@mail.ustc.edu.cn>
2007-03-16 8:48 ` [PATCH 01/14] readahead: state based method: check node id Fengguang Wu
[not found] ` <20070316085051.787637000@mail.ustc.edu.cn>
2007-03-16 8:48 ` [PATCH 02/14] readahead: state based method: decouple readahead_ratio from growth_limit Fengguang Wu
[not found] ` <20070316085051.939153000@mail.ustc.edu.cn>
2007-03-16 8:48 ` [PATCH 03/14] readahead: state based method: cancel lookahead gracefully Fengguang Wu
[not found] ` <20070316085052.111038000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 04/14] readahead: thrashing recovery method: check unbalanced aging Fengguang Wu
[not found] ` <20070316085052.284256000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 05/14] readahead: thrashing recovery method: refill holes Fengguang Wu
[not found] ` <20070316085052.388486000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 06/14] readahead: call scheme: cleanup Fengguang Wu
[not found] ` <20070316085052.550263000@mail.ustc.edu.cn>
2007-03-16 8:49 ` Fengguang Wu [this message]
[not found] ` <20070316085052.688674000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 08/14] readahead: remove parameter ra_max from thrashing_recovery_readahead() Fengguang Wu
[not found] ` <20070316085052.868849000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 09/14] readahead: remove parameter ra_max from adjust_rala*() Fengguang Wu
[not found] ` <20070316085053.030235000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 10/14] readahead: state based method: protect against tiny size Fengguang Wu
[not found] ` <20070316085053.155226000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 11/14] readahead: rename state_based_readahead() to clock_based_readahead() Fengguang Wu
[not found] ` <20070316085053.339604000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 12/14] readahead: account I/O block times for stock readahead Fengguang Wu
[not found] ` <20070316085053.463858000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 13/14] readahead: rescue_pages() updates Fengguang Wu
[not found] ` <20070316085053.642868000@mail.ustc.edu.cn>
2007-03-16 8:49 ` [PATCH 14/14] readahead: remove noaction/shrink events Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=374035059.35424@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox