From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbeBWOit (ORCPT ); Fri, 23 Feb 2018 09:38:49 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:57316 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbeBWOio (ORCPT ); Fri, 23 Feb 2018 09:38:44 -0500 Subject: Re: [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, gustavo@padovan.org, jgross@suse.com, konrad.wilk@oracle.com Cc: Oleksandr Andrushchenko References: <1519200222-20623-1-git-send-email-andr2000@gmail.com> <1519200222-20623-2-git-send-email-andr2000@gmail.com> <1c569896-e60c-bed3-fda8-c72b8d0a349d@gmail.com> From: Boris Ostrovsky Message-ID: <3740a458-35d7-b51d-5cd0-be3bebd87574@oracle.com> Date: Fri, 23 Feb 2018 09:39:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1c569896-e60c-bed3-fda8-c72b8d0a349d@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8812 signatures=668677 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=711 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802230183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2018 01:37 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 12:23 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> +static struct xenbus_driver xen_driver = { >>> + .ids = xen_drv_ids, >>> + .probe = xen_drv_probe, >>> + .remove = xen_drv_remove, >>> + .otherend_changed = backend_on_changed, >> What does "_on_" stand for? > Well, it is somewhat like a hint that this is called "on" event, > e.g. event when the other end state has changed, backend in this > case. It could be something like "backend_on_state_changed" If you look at other xenbus_drivers none of the uses this so I think we should stick to conventional naming. (and the same applies to other backend_on_* routines). -boris