From: Arnd Bergmann <arnd@arndb.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
y2038@lists.linaro.org, Hannes Reinecke <hare@suse.com>,
Mike Christie <mchristi@redhat.com>, Shaohua Li <shli@fb.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blktrace: avoid using timespec
Date: Sat, 18 Jun 2016 21:02:08 +0200 [thread overview]
Message-ID: <3744206.k1Hv7RyTzG@wuerfel> (raw)
In-Reply-To: <x494m8r5vnb.fsf@segfault.boston.devel.redhat.com>
On Friday, June 17, 2016 5:54:16 PM CEST Jeff Moyer wrote:
> Jens Axboe <axboe@kernel.dk> writes:
>
> > On 06/17/2016 05:36 PM, Steven Rostedt wrote:
> >>
> >> Jens,
> >>
> >> You want to take this, or do you want me to?
> >
> > I'll add it to my 4.8 tree, thanks Arnd.
>
> + /* need to check user space to see if this breaks in y2038 or y2106 */
>
> Userspace just uses it to print the timestamp, right? So do we need the
> comment?
If we have more details, the comment should describe what happens and
when it overflows. If you have the source at hand, maybe you can answer
these:
How does it print the timestamp? Does it print the raw seconds value
using %u (correct) or %d (incorrect), or does it convert it into
year/month/day/hour/min/sec?
In the last case, how does it treat second values above 0x80000000? Are
those printed as year 2038 or year 1902?
Are we sure that there is only one user space implementation that reads
these values?
Arnd
next prev parent reply other threads:[~2016-06-18 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 14:58 [PATCH] blktrace: avoid using timespec Arnd Bergmann
2016-06-17 15:36 ` Steven Rostedt
2016-06-17 21:39 ` Jens Axboe
2016-06-17 21:54 ` Jeff Moyer
2016-06-18 19:02 ` Arnd Bergmann [this message]
2016-06-20 14:59 ` Jeff Moyer
2016-06-20 15:18 ` Arnd Bergmann
2016-06-20 19:37 ` Jeff Moyer
2016-06-20 20:01 ` [Y2038] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3744206.k1Hv7RyTzG@wuerfel \
--to=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shli@fb.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox