From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030422AbbJ3I3x (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2015 04:29:53 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:60724 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1030407AbbJ3I3r (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2015 04:29:47 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Jens Kuske <jenskuske@gmail.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Emilio =?ISO-8859-1?Q?L=F3pez?= <emilio@elopez.com.ar>,
        devicetree@vger.kernel.org,
        Vishnu Patekar <vishnupatekar0510@gmail.com>,
        linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
        linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support
Date: Fri, 30 Oct 2015 09:28:55 +0100
Message-ID: <3751073.AWmm18dvKK@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1445964626-6484-3-git-send-email-jenskuske@gmail.com>
References: <1445964626-6484-1-git-send-email-jenskuske@gmail.com> <1445964626-6484-3-git-send-email-jenskuske@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:Y7OE2ANOsIZrbdrSWUzmX3737JIPNjSJHb7+pozJ4WvQljxCtWm
 FfEO+ZOd7H6BVX8EGdhkYRuZl1yfOouuQRTf+T+M7TFzDkXNoeimwgBqK6339FKY/mZ2FNK
 P/+uGDKIfhX0XgiOJOpjB10QpLwVHrTl/FxlkRT9njeI7iIc9XCcVcwT9HfLhK82gP9ve1x
 wZ1mnAf2YR/qgZJB/z1UQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:6qS298pjDCo=:TnuLI3IOxtK13/u7nliIU3
 jtG0AkzeoxpUAV7zNhA3Q47JdG0Vyh4lS9OwkbH1MIQ2CjMDFcrAbiNXYQjuyvAEGD8VnFMR3
 f4XJI0BUhvfV6K1wnXr1zyVtjFuLDc6N9NEo83DGjZTzpe3LKG5eecIz6ZYMGpt3/+z7Tkoxr
 V7H6j3bX41m9tNwHpLAvincKOLffSGk/P+glcEyKokyWCNu2F62qc4aYDsED9BJz2fKLSBfhN
 PiVSSHfvTgQQI7+sZbADtpr/zZVaKCxmcAYWu3fYGD7uWRmaYrrQYc3KLuNIq4VDcR7bg0o7D
 NSWfgBjc+vaFc4Tdk6A9MW3Cf+oD14T5Fce5l4IGUy6I084uKgKZ4qYbpb5ZaCXTDhkDSOjgB
 Zx8ZtCtZz7oMiI98Ob6Mc6v0xQtkjYxev8QRagjfh7iA8ckVoVux1WO8tfO2ZKcsO+XOMnS2D
 73KqPrELzrOuZIeRP/kUaXbhTWwTvy429E7ltZrH8xMHCeTp4dHhmyxesVKjFDuyn6nOd2OZF
 urSuI+8A6/jlZncMfNepd/0Z8+qPO0WLLCQaMvIYeFYGU0qUpDXr6gFLdPkGp63RJPyShzY4q
 jXiWckDp00vH/o99L+u6BQUOijEff2cRXswrseeygxwupChInva/MnSn7wRLTxExBM278nmOd
 Sh6OkttW1xkZfXOIN/dobS/vt9rvZJ+JJ7EzhCeezrpK9ziHs5MuK4StreeP1wQk3mzSpL4Nd
 4HRR+T9EpHkOmk+c
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 27 October 2015 17:50:22 Jens Kuske wrote:
> +               of_property_read_string_index(node, "clock-output-names",
> +                                             i, &clk_name);
> +
> +               if (index == 17 || (index >= 29 && index <= 31))
> +                       clk_parent = AHB2;
> +               else if (index <= 63 || index >= 128)
> +                       clk_parent = AHB1;
> +               else if (index >= 64 && index <= 95)
> +                       clk_parent = APB1;
> +               else if (index >= 96 && index <= 127)
> +                       clk_parent = APB2;
> +
> +               clk_reg = reg + 4 * (index / 32);
> 

Same as for the reset driver, this probably means you should have one
cell to indicate which bus it is for, and another cell for the
index.

	Arnd